[RFC trivial] printk.c: /proc/vmcore instead of /proc/vmcoreinfo in comments?

[RFC trivial] printk.c: /proc/vmcore instead of /proc/vmcoreinfo in comments?

[Dirk Gouders]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

Hello Joe,

when having a look at printk.c, I noticed that two comments refer
to /proc/vmcoreinfo and I wonder if that should not read /proc/vmcore.

While at it, a typo in one of those coments could also be fixed.

Best regards,

Dirk


[-- Attachment #2: Patch --]
[-- Type: text/plain, Size: 1158 bytes --]

>From 2ef84ff3187633a3156c3a967c1dfc294292e492 Mon Sep 17 00:00:00 2001
From: Dirk Gouders <dirk@gouders.net>
Date: Tue, 22 Oct 2013 13:51:15 +0200
Subject: [PATCH] printk.c: comments should refer to /proc/vmcore instead of
 /proc/vmcoreinfo

In one of those comments a typo was fixed, too.

Signed-off-by: Dirk Gouders <dirk@gouders.net>
---
 kernel/printk/printk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index b4e8500..694d1f9 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -705,9 +705,9 @@ const struct file_operations kmsg_fops = {
 
 #ifdef CONFIG_KEXEC
 /*
- * This appends the listed symbols to /proc/vmcoreinfo
+ * This appends the listed symbols to /proc/vmcore
  *
- * /proc/vmcoreinfo is used by various utiilties, like crash and makedumpfile to
+ * /proc/vmcore is used by various utilities, like crash and makedumpfile to
  * obtain access to symbols that are otherwise very difficult to locate.  These
  * symbols are specifically used so that utilities can access and extract the
  * dmesg log from a vmcore file after a crash.
-- 
1.8.3.2

Re: [RFC trivial] printk.c: /proc/vmcore instead of /proc/vmcoreinfo in comments?

[Joe Perches]

On Tue, 2013-10-22 at 14:15 +0200, Dirk Gouders wrote:
> Hello Joe,
> 
> when having a look at printk.c, I noticed that two comments refer
> to /proc/vmcoreinfo and I wonder if that should not read /proc/vmcore.
> 
> While at it, a typo in one of those coments could also be fixed.

Hi Dirk.

Thanks and yes this is sensible.
Adding Andrew Morton to cc's and resending as plain-text

>From 2ef84ff3187633a3156c3a967c1dfc294292e492 Mon Sep 17 00:00:00 2001
From: Dirk Gouders <dirk@gouders.net>
Date: Tue, 22 Oct 2013 13:51:15 +0200
Subject: [PATCH] printk.c: comments should refer to /proc/vmcore instead of
 /proc/vmcoreinfo

In one of those comments a typo was fixed, too.

Signed-off-by: Dirk Gouders <dirk@gouders.net>
---
 kernel/printk/printk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index b4e8500..694d1f9 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -705,9 +705,9 @@ const struct file_operations kmsg_fops = {
 
 #ifdef CONFIG_KEXEC
 /*
- * This appends the listed symbols to /proc/vmcoreinfo
+ * This appends the listed symbols to /proc/vmcore
  *
- * /proc/vmcoreinfo is used by various utiilties, like crash and makedumpfile to
+ * /proc/vmcore is used by various utilities, like crash and makedumpfile to
  * obtain access to symbols that are otherwise very difficult to locate.  These
  * symbols are specifically used so that utilities can access and extract the
  * dmesg log from a vmcore file after a crash.
-- 
1.8.3.2

Re: [RFC trivial] printk.c: /proc/vmcore instead of /proc/vmcoreinfo in comments?

[Dirk Gouders]

Joe Perches <joe@perches.com> writes:

> On Tue, 2013-10-22 at 14:15 +0200, Dirk Gouders wrote:
>> Hello Joe,
>> 
>> when having a look at printk.c, I noticed that two comments refer
>> to /proc/vmcoreinfo and I wonder if that should not read /proc/vmcore.
>> 
>> While at it, a typo in one of those coments could also be fixed.
>
> Hi Dirk.
>
> Thanks and yes this is sensible.
> Adding Andrew Morton to cc's and resending as plain-text

Hi Joe and Andrew,

thank you for reviewing and accepting (indicated by another mail from
Andrew) this patch.

Dirk


> From 2ef84ff3187633a3156c3a967c1dfc294292e492 Mon Sep 17 00:00:00 2001
> From: Dirk Gouders <dirk@gouders.net>
> Date: Tue, 22 Oct 2013 13:51:15 +0200
> Subject: [PATCH] printk.c: comments should refer to /proc/vmcore instead of
>  /proc/vmcoreinfo
>
> In one of those comments a typo was fixed, too.
>
> Signed-off-by: Dirk Gouders <dirk@gouders.net>
> ---
>  kernel/printk/printk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index b4e8500..694d1f9 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -705,9 +705,9 @@ const struct file_operations kmsg_fops = {
>  
>  #ifdef CONFIG_KEXEC
>  /*
> - * This appends the listed symbols to /proc/vmcoreinfo
> + * This appends the listed symbols to /proc/vmcore
>   *
> - * /proc/vmcoreinfo is used by various utiilties, like crash and makedumpfile to
> + * /proc/vmcore is used by various utilities, like crash and makedumpfile to
>   * obtain access to symbols that are otherwise very difficult to locate.  These
>   * symbols are specifically used so that utilities can access and extract the
>   * dmesg log from a vmcore file after a crash.