Re: [RFC] convert ftrace syscall tracer to TRACE_EVENT()

Frédéric Weisbecker
2009-05-09T14:12:26Z

Le 9 mai 2009 16:07, Ingo Molnar <mingo@elte.hu> a écrit :
>
> * Frédéric Weisbecker <fweisbec@gmail.com> wrote:
>
>> > Note, this assumes that all syscall types can be described via
>> > __field() - i think that's correct. (we dont want to deref
>> > strings as they are untrusted, and there are no arrays in
>> > syscall parameters)
>>
>> Yeah, but we can also define a __string_from_user(), should be
>> trivial.
>
> We cannot really do that, because we cannot check the type in a
> macro. So we dont know when to inject __field() versus
> __string_from_user().

Aah...you're right :-/

>
>> > Can you see any complication?
>>
>> Just about the order of headers to include and headers
>> dependencies....
>
> That is testable and any problems will be found at the build stage,
> so it should be solvable.
>
>        Ingo
>