Re: [RFC] convert ftrace syscall tracer to TRACE_EVENT()

Ingo Molnar
2009-05-09T14:16:33Z

* Frédéric Weisbecker <fweisbec@gmail.com> wrote:

> > I would expect to use copy_string_from_user (for strings) and
> > copy_from_user for structures, because without any strings
> > (especially), the trace information become much less useful.
>
> Yeah, for structures we would just need the copy_from_user.

There's just a few places (mainly related to VFS APIs) where we
really want to do that, and there we want to do it a bit later, not
at syscall time: we want to do it after the getname(), to output a
stable (and already copied to kernel space) copy of the file name.

So the right solution there would be to add special, case by case
tracepoints to those few places. We dont need strings for the
majority of the 300+ system calls that exist on Linux.

Ingo