Re: LZO irreversible output?

[Bill Davidsen <davidsen@tmr.com>]

Nigel Cunningham wrote:
> Hi Rafael.
> 
> Rafael J. Wysocki wrote:
>> On Wednesday 03 February 2010, Nigel Cunningham wrote:
>>> Hi all.
>>>
>>> (Not sent to LKML yesterday; no reply from linux-crypto yet, so resending).
>>>
>>> A while back now, I stopped supplying the LZF compression algorithm with
>>> TuxOnIce and made LZO the default algorithm. Around the same time, we
>>> started getting occasional errors when reading images; decompression
>>> failures.
>>>
>>> I've finally managed to find the time to properly look at this, and have
>>> managed to find a data page that LZO compresses, but seems to be unable
>>> to decompress back to the original contents. I'm wondering whether this
>>> is because I'm doing something wrong, or because there really is some
>>> data the LZO (or the kernel implementation) can't do reversible
>>> compression on.
>> Well, FWIW, we have never had any problems with the userland LZO in s2disk,
>> so if anything is wrong with LZO here, I guess it's the kernel code.
> 
> Okay. Guess I have to start shipping LZF again and make it the default
> again then.
> 
I would hope someone will look at the real problem, though, that LZO isn't 
working properly. I have to assume that either the kernel decompress is broken 
or that the page you have given is invalid, and the error lies in the compression.

It doesn't look as if you are doing something wrong, it looks broken.

-- 
Bill Davidsen <davidsen@tmr.com>
   "We have more to fear from the bungling of the incompetent than from
the machinations of the wicked."  - from Slashdot