Re: [patch] video/sn9c102: improve error handling

["Christophe JAILLET" <christophe.jaillet@wanadoo.fr>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

Hi,

this patch seems incomplete.

You had an opening { wityhout the corresponding }.

Best regards,
Christophe Jaillet.

"Dan Carpenter" <error27@gmail.com> a écrit
dans le message de news:20100328115005.GW5069@bicker...
> Return an error if the controller is not found.
>
> Signed-off-by: Dan Carpenter
<error27@gmail.com>
>
> diff --git a/drivers/media/video/sn9c102/sn9c102_core.c
b/drivers/media/video/sn9c102/sn9c102_core.c
> index cbf8087..28e19da 100644
> --- a/drivers/media/video/sn9c102/sn9c102_core.c
> +++ b/drivers/media/video/sn9c102/sn9c102_core.c
> @@ -2295,7 +2295,7 @@ sn9c102_vidioc_s_ctrl(struct sn9c102_device* cam,
void __user * arg)
>   if (copy_from_user(&ctrl, arg, sizeof(ctrl)))
>   return -EFAULT;
>
> - for (i = 0; i < ARRAY_SIZE(s->qctrl); i++)
> + for (i = 0; i < ARRAY_SIZE(s->qctrl); i++) {
>   if (ctrl.id == s->qctrl[i].id) {
>   if (s->qctrl[i].flags & V4L2_CTRL_FLAG_DISABLED)
>   return -EINVAL;
> @@ -2305,7 +2305,9 @@ sn9c102_vidioc_s_ctrl(struct sn9c102_device* cam,
void __user * arg)
>   ctrl.value -= ctrl.value % s->qctrl[i].step;
>   break;
>   }