From: WANG Cong <xiyou.wangcong@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crash_dump: export is_kdump_kernel to modules, consolidate elfcorehdr_addr, setup_elfcorehdr and saved_max_pfn
Date: Wed, 26 Jan 2011 05:24:27 +0000 (UTC) [thread overview]
Message-ID: <ihob6b$kmn$3@dough.gmane.org> (raw)
In-Reply-To: 20110125161052.GA20105@aepfle.de
On Tue, 25 Jan 2011 17:10:52 +0100, Olaf Hering wrote:
> The Xen PV drivers in a crashed HVM guest can not connect to the dom0
> backend drivers because both frontend and backend drivers are still in
> connected state. To run the connection reset function only in case of a
> crashdump, the is_kdump_kernel() function needs to be available for the
> PV driver modules.
>
> Consolidate elfcorehdr_addr, setup_elfcorehdr and saved_max_pfn into
> kernel/crash_dump.c Also export elfcorehdr_addr to make
> is_kdump_kernel() usable for modules.
>
> Leave 'elfcorehdr' as early_param(). This changes powerpc from
> __setup() to early_param(). It adds an address range check from x86
> also on ia64 and powerpc.
>
Hmm, once we export is_kdump_kernel() I bet some driver will start
to use it to "fix" kdump problem, which definitely is a wrong approach.
I am not familiar with Xen at all, don't know why you have to use
is_kdump_kernel() in this case. You need to persuade people to believe
this is a fix not a workaround. :)
next prev parent reply other threads:[~2011-01-26 5:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 16:10 [PATCH] crash_dump: export is_kdump_kernel to modules, consolidate elfcorehdr_addr, setup_elfcorehdr and saved_max_pfn Olaf Hering
2011-01-26 5:24 ` WANG Cong [this message]
2011-01-27 0:04 ` Andrew Morton
2011-01-27 10:47 ` Olaf Hering
2011-01-27 22:49 ` Andrew Morton
2011-01-27 2:43 ` Vivek Goyal
2011-01-27 10:57 ` Olaf Hering
2011-01-27 22:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ihob6b$kmn$3@dough.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).