From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E673442EEBA for ; Mon, 13 Jul 2026 13:47:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783950449; cv=none; b=IlfwyV2yKZ/XgKDWGLcb1D6V1Bh6RY2EBsBV3w4MHohtrLZQn/ALbMvfD/eYI3t10IOqIzlX+auHyTc2l6ZmjALAbjL4By7vJNZheoA3hW2IRZlIAdoCjEZbALjmKNn52KJAcVGNd7+9y5QESEMkFgw3hnlZYYSRmu1z1THYVOE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783950449; c=relaxed/simple; bh=m3r23/EnqIHFr/YwnaZyYrWiafwQEeXhBtxLRj2wHGE=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=TvHCKqMNpexO9AE1Sf3Xb1SEGyhVd9gsV7MkY2484NRAdojbsHWbdHrBk6TYm8UE0yEr+D5qfwmyWHD5/Z990w5YgXNnpWk3UJjiai0byI8ND4gl4H8SZtkxmfoyyeb6MI40wU+f+zk6gR8VeW2GGIeEzqyi90KOMRHSWv+Lof4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rQEqLPnA; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rQEqLPnA" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-ca97d139d5fso2230693a12.0 for ; Mon, 13 Jul 2026 06:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783950446; x=1784555246; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=DidKVYu0F2Emj2o37zWQ67YKMQ/cqUiWa4PnHuuYDj4=; b=rQEqLPnA66c/evB/gTE7Ul4j7w0KKqILWVzTCTAh0WrcEsGsflq3XUxdRGiaH2AW8w UqFDBuaXC6DuPYqIlssVNaiKIUbCD7QsnoRAIHyzGqtKHE6XmzIxX3piv7m0thOnY+k1 oQRM/flgQvpcNcazZsug1B3MoGsBj0bcBoRLD9H24604KLfKjkcAWgh51+brGEmTDUAG pEeSN0iOnq3V4Ypnq5rw8lgCGW8d8CvobFrViDKpac976x/5ddS6sCzohkKfq74xI75s M8NV5Uk7+aFXe10+u7SfKwk2KUrKlS3BM9DBf+FKKtAbUObI4n5gkQ7MkIj9q0hYYIKY ZH5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783950446; x=1784555246; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DidKVYu0F2Emj2o37zWQ67YKMQ/cqUiWa4PnHuuYDj4=; b=sS9IWqUL2G5PpmgnoDg0IZ/n1oykX/kbqwbxTwIdzcZ61BMwT/Lv7skrFVZLXnLOCt /sYs982lgZlq39+3+BBnjcoCf5KXZAAvcsbzaLfJlxgb08r63weCLSBdo7yIa1XbaYxN E5qk8b0U2Q7ds3PBkWIo7VIVrHsBiRxOhSIxUguEdQvTOVS9opJt1rh/2dnyiXk/uJH9 cfaiEgHFdxUHseXERgHJag4XqqzNhJbNPldKcW0wOLSR5W6ml1LkFTOSFI/G4BSIrgyO GJ9xGRKIgRrmA6XtwWn7OI2oJ4mK7qdDZ35x7Hgpxq1HooiBInHIQGwRhStnWDKXwPsG HKTw== X-Forwarded-Encrypted: i=1; AHgh+Ro0VSdPwhwl7wH23DgH565WkpUNr60EJnQ+vVHIFZqLXnJp6i89a0VlrkwUN4GQ56sA5hPfA6qdHvKl5VY=@vger.kernel.org X-Gm-Message-State: AOJu0YxLvRhSUH7HQsbd8jfH8dzGZr7xnPzVoEJBRgf4du6bLrgRFfyj cvJWf4sfR5us7jCTPVRCare+0eI2xwkmg6AF7sVS/EXsBsgDR4JnDODp7XRjJQ== X-Gm-Gg: AfdE7clxCva1EF4Y8v82oTKp2PBrdygfAR3IGHPxR/wT/EtbA0r37UL+9Ji1UxzWXMP uGbBQo/qp+KqdjwUeKu/87EKk3LHeSVyugEYQCEVN5AznRtH1/h+yJWRrcfEVnIAJp1XC9uOAex DDRG0xCcYUKWkyeq36kEqqnIyd2dK/m0mR8/ETP0gOA0XvQ2IIfAY9grzHNR1HbVghhP/QnqGxU xrbPIcjILd5NGmSEWGWJqnVDXp140w6RUIQKf6zmHg0Mp6hZkJHrM69norffCvG2qg8uUTEzkox +lZP3dnV2EhgE/UWhlaJ/xT1VR4TwcbCdvcmAAvErrQ1zIeDBcy4kLZSV1fwmTdMF2gkRr82qac 81N/AtQvySY3dJOuI7H80LkIqFe04dZEZAWs7VyaBXD1AvXGr3RWPfKJx3UjCQcXo9xXTAyAz8f DL0O5snG8X3iY= X-Received: by 2002:a05:6a21:3383:b0:3bd:229c:dcab with SMTP id adf61e73a8af0-3c1108b490emr11781651637.17.1783950446099; Mon, 13 Jul 2026 06:47:26 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174839f89sm71169157eec.10.2026.07.13.06.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 06:47:25 -0700 (PDT) From: Ritesh Harjani (IBM) To: Thorsten Blum , Geoff Levand , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Geert Uytterhoeven , Paul Mackerras , MOKUNO Masakazu Cc: Thorsten Blum , stable@vger.kernel.org, Geoff Levand , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/ps3: Fix map failure path in dma_ioc0_map_pages() In-Reply-To: <20260711130931.740719-3-thorsten.blum@linux.dev> Date: Mon, 13 Jul 2026 18:08:56 +0530 Message-ID: References: <20260711130931.740719-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thorsten Blum writes: > If lv1_put_iopte() fails in dma_ioc0_map_pages(), the error path > decrements iopage but keeps using the failed mapping's offset. As a > result, it repeatedly tries to invalidate the failed IOPTE slot and > leaves the already installed IOPTEs valid. > > Recompute offset and invalidate the installed IOPTEs instead. > Nice catch! I wonder how did you catch this? Do you have ps3 console where you somehow ran into this ;) Or was it a manual inspection? I wonder whether PS3 consoles are still being used? > Fixes: 6bb5cf102541 ("[POWERPC] PS3: System-bus rework") Looks like this was from 2007. However, the change looks good to me. So: Reviewed-by: Ritesh Harjani (IBM) > Cc: stable@vger.kernel.org > Signed-off-by: Thorsten Blum > --- > arch/powerpc/platforms/ps3/mm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/platforms/ps3/mm.c b/arch/powerpc/platforms/ps3/mm.c > index 20fc5b68faee..315a32fd75b1 100644 > --- a/arch/powerpc/platforms/ps3/mm.c > +++ b/arch/powerpc/platforms/ps3/mm.c > @@ -615,6 +615,7 @@ static int dma_ioc0_map_pages(struct ps3_dma_region *r, unsigned long phys_addr, > > fail_map: > for (iopage--; 0 <= iopage; iopage--) { > + offset = (1 << r->page_size) * iopage; > lv1_put_iopte(0, > c->bus_addr + offset, > c->lpar_addr + offset,