From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D372D33F588 for ; Sat, 21 Mar 2026 05:11:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774069875; cv=none; b=mxvJOv6hQG/SFrltp700/fdqTAFkn6UcyvbjAlCf0Psc9lfOqVrLYOljA0DyK/D4g5d4FH2Qa1i4Lr9CelUBnG2TmmuDYhAsiu7j0iLkfgQ5ciC7Pq3TYVtq7nvpEPjSR+5VbBCVCA4LTYkPyKAJwrKq79voxaki1YTC1708vKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774069875; c=relaxed/simple; bh=qVwlCu1WIXntn26q1kvsy4ns7XCLQh3LUnFd91zRr48=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=N+1cvW0vrAstbfbWH+/6sFGXOWVzarsuR/OBHrJGFzLIWGl3X33fGWdV0dyiVYpvpa7VpFRA6AFDylttRjgc6sDh9MbR2LWc6r8qn10iuDA5NlUJrexkjwpyYW3yxEcI9FNoL1/dE0u+68YWf4yhcmPL6jjezXiFOn+K9BnmxsM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OLe7OxhB; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OLe7OxhB" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-82748257f5fso2462858b3a.1 for ; Fri, 20 Mar 2026 22:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774069873; x=1774674673; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=7QxDv7wA5vy2wx/iALi99txiEfbwQ3ENlpnWZYhHz0A=; b=OLe7OxhBzFwMPIltVknpGrXU9DN7TZFVr3dJDvog+FEKXYmG+fHE2bFbgoZCuFCuw2 0eJIPaT+MwpkQBDn5zFbJSu9h2HQa0J7qzB1ZsadIyJ8Bau/FOCcW7WsotI/JazwbOwC Liacvp0OhfIMtoPN1/bsxA1AetNrt12rxXcHel3gly35cWWZocy2wqHD4vswnXxER4SK TKXch+jKp5VDm59qDJg8ua+0OqFS8JstiSXF1Pwy5A8Zcue6JB5wdTTc5OSZOMyh9cCw BYWG4YhdCWoTZ4G1qzRqr0iGs0BgB00W7fAJFkySqVoTIt3dNWFPgkagFcG568A1/AfF xj/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774069873; x=1774674673; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7QxDv7wA5vy2wx/iALi99txiEfbwQ3ENlpnWZYhHz0A=; b=sxCnWZsZgtJ73YR0smJdoL2Dj4Rpk18Wo6jTcl1akj5/7coQqG0Imyesh1VACl7gTl l7KKralbzWmbgSJSn7lAPkq+w7WYzry3Ce24b2s/xOwTOcyibFvHI2in3KzNyfg0kpxk Y7qrfAvxC/F8rN5aUIu1VkRgvUrfDk1AKCv7chSmqsFkshP9H9ph+AaXVE20kMyV9Ajy dXKjFT/H5yVWCIZkkd/fVEdKJH3ZPJRDK0CwkS+8ESX1wzqCCueXs6MGGyuV61DKjUOd WAGAidFOukDtEasQqE/WRomcyh6+Jj9JBO8xWQboOubkWUP21UZCI+u0G9E31IpdNBde 4pFw== X-Forwarded-Encrypted: i=1; AJvYcCUrtVtkkqMQsn5mtX6MtTNJQDVw+hv0rr2wopcltREseGMMHi6RE8LZRf6KRtaqbEBQsG47cjuXkQgSrHc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0gVtwPZ4kbdbtESzkbDFq6frT3v/E1xIl80C0fBh89a6vpH+V d5uWje1PaT74klVe32Gh4rXDEeNA/sh8vOAHOQgT32quEe5ZkGGMVM2wj8COpuqA X-Gm-Gg: ATEYQzwLJx6Z3vpRgzg/rVI/nJcx13nCUsfGmz43LysRyFJe0xA/3TKNb2Uw18CoCuQ f9QPLuNAMYE8ushFBQU/yNtimBbdsq5T+v2ABJ6et1DYfRdS6mRAjM7jNpMl0FXXhnIZLffO0ui RXvBxVlvX0ZIC77n2TNSPdvHdikgGHxvEL/1+5jQxyjZKgwH5OPQSh6FVZSIUAlswzUAyE8zcbT FYxNeeLdw2vQD7PV+t3MF9hZjqCmdGmN/pSiL1ntea826mKY9ywsy248pStgyRV2VtTqbykZTAx Z74Ux+EEK6Jq1QovaL8grldkmceGBOBukBnImUf07nn9LJKvIVSwJWgKuLJ/6pzHZzDyMp7mxhR kv3ivN8eBe48gCOnXbxk6tVdTd8PwXrgquIn3fgNqFPg+nzHnw1PoBts7wHCFYsz+AfqEPY65th u8AHeVVgoMoA9MFm12RvHxGQ== X-Received: by 2002:a05:6a21:4cca:b0:39b:9c3a:f54f with SMTP id adf61e73a8af0-39bb25e7511mr8216718637.32.1774069873215; Fri, 20 Mar 2026 22:11:13 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c743a939af0sm2729778a12.16.2026.03.20.22.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 22:11:12 -0700 (PDT) From: Ritesh Harjani (IBM) To: Baolin Wang , akpm@linux-foundation.org, david@kernel.org Cc: ljs@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, baolin.wang@linux.alibaba.com, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, open , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] mm: change to return bool for ptep_test_and_clear_young() In-Reply-To: <3fa94c3c89fd93fe22c8cb59967f064787d686aa.1773890510.git.baolin.wang@linux.alibaba.com> Date: Fri, 20 Mar 2026 11:27:48 +0530 Message-ID: References: <3fa94c3c89fd93fe22c8cb59967f064787d686aa.1773890510.git.baolin.wang@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Baolin Wang writes: > Callers use ptep_test_and_clear_young() to clear the young flag and check > whether it was set. Change the return type to bool to make the intention > clearer. > Right I checked all callers of ptep_test_and_clear_young(). I agree, we only need bool here. > Signed-off-by: Baolin Wang > --- > arch/arm64/include/asm/pgtable.h | 8 ++++---- > arch/arm64/mm/contpte.c | 4 ++-- > arch/microblaze/include/asm/pgtable.h | 2 +- > arch/parisc/include/asm/pgtable.h | 6 +++--- > arch/powerpc/include/asm/book3s/32/pgtable.h | 4 ++-- > arch/powerpc/include/asm/book3s/64/pgtable.h | 6 +++--- > arch/powerpc/include/asm/nohash/pgtable.h | 4 ++-- I looked at it because of powerpc changes, but ended up looking into all call sites anyways. So overall it LGTM (and I agree that we can remove the unnecessary externs from function declarations) With that please feel free to add: Reviewed-by: Ritesh Harjani (IBM)