public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Pty is losing bytes
Date: Tue, 15 Feb 2005 21:30:06 +0100	[thread overview]
Message-ID: <je1xbhy3ap.fsf@sykes.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0502151053060.5570@ppc970.osdl.org> (Linus Torvalds's message of "Tue, 15 Feb 2005 11:08:07 -0800 (PST)")

Linus Torvalds <torvalds@osdl.org> writes:

> I think it may be a n_tty line discipline bug, brought on by the fact that
> the PTY buffering is now 4kB rather than 2kB. 4kB is also the
> N_TTY_BUF_SIZE, and if n_tty has some off-by-one error, that would explain 
> it.

I've also seen more than one byte missing.  For example when sending a big
chunk of bytes down the pty via an Emacs *shell* buffer up to 16 bytes are
missing somewhere in the middle.

> Does the problem go away if you change the default value of "chunk" (in 
> drivers/char/tty_io.c:do_tty_write) from 4096 to 2048?

Yes, that helps.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  parent reply	other threads:[~2005-02-15 20:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-15  0:54 Pty is losing bytes Andreas Schwab
2005-02-15 19:08 ` Linus Torvalds
2005-02-15 19:44   ` Linus Torvalds
2005-02-15 22:13     ` Alan Cox
2005-02-15 19:58   ` Sergey Vlasov
2005-02-15 20:13     ` Sergey Vlasov
2005-02-15 20:06   ` Alan Curry
2005-02-15 20:30   ` Andreas Schwab [this message]
2005-02-15 20:56     ` Linus Torvalds
2005-02-15 21:54       ` Andreas Schwab
2005-02-16  3:12       ` Roman Zippel
2005-02-16  4:05         ` Linus Torvalds
2005-02-16 14:42           ` Theodore Ts'o
2005-02-16 16:06             ` Linus Torvalds
2005-02-17  4:44               ` Theodore Ts'o
2005-02-17 15:45                 ` Linus Torvalds
2005-02-18 16:32                   ` Theodore Ts'o
2005-02-16 19:49           ` Roman Zippel
2005-02-16 19:58             ` Linus Torvalds
2005-02-16 22:46               ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2005-02-15  2:00 Alex Davis
2005-02-15 10:48 ` Andreas Schwab
2005-02-15 11:01   ` Jan De Luyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=je1xbhy3ap.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox