From: Andreas Schwab <schwab@suse.de>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>,
trivial@kernel.org
Subject: Re: [PATCH] ixgb: Delete IXGB_DBG() macro and call pr_debug() directly.
Date: Tue, 10 Oct 2006 14:12:41 +0200 [thread overview]
Message-ID: <je4pucxtc6.fsf@sykes.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0610100738540.7436@localhost.localdomain> (Robert P. J. Day's message of "Tue, 10 Oct 2006 07:59:35 -0400 (EDT)")
"Robert P. J. Day" <rpjday@mindspring.com> writes:
> Remove the minimally-useful definition of IXGB_DBG() and have
> ixgb_main.c call pr_debug() directly.
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> ---
> diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h
> index 50ffe90..fb9fde5 100644
> --- a/drivers/net/ixgb/ixgb.h
> +++ b/drivers/net/ixgb/ixgb.h
> @@ -77,12 +77,6 @@ #include "ixgb_hw.h"
> #include "ixgb_ee.h"
> #include "ixgb_ids.h"
>
> -#ifdef _DEBUG_DRIVER_
> -#define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args)
^^^^^^^^
> -#else
> -#define IXGB_DBG(args...)
> -#endif
> -
> #define PFX "ixgb: "
> #define DPRINTK(nlevel, klevel, fmt, args...) \
> (void)((NETIF_MSG_##nlevel & adapter->msg_enable) && \
> diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
> index e09f575..d063e84 100644
> --- a/drivers/net/ixgb/ixgb_main.c
> +++ b/drivers/net/ixgb/ixgb_main.c
> @@ -1948,7 +1948,7 @@ #endif
>
> /* All receives must fit into a single buffer */
>
> - IXGB_DBG("Receive packet consumed multiple buffers "
> + pr_debug("Receive packet consumed multiple buffers "
Would perhaps be useful to retain the "ixgb:" prefix.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-10-10 12:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 11:59 [PATCH] ixgb: Delete IXGB_DBG() macro and call pr_debug() directly Robert P. J. Day
2006-10-10 12:12 ` Andreas Schwab [this message]
2006-10-10 12:15 ` Robert P. J. Day
-- strict thread matches above, loose matches on Subject: below --
2006-10-10 12:19 Robert P. J. Day
2006-10-10 16:14 ` Auke Kok
2006-10-10 16:36 ` Robert P. J. Day
2006-10-10 16:50 ` Auke Kok
2006-10-10 17:51 ` Robert P. J. Day
2006-10-10 18:18 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je4pucxtc6.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox