public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Michael Buesch <mb@bu3sch.de>
Cc: benh@kernel.crashing.org, linuxppc-dev@ozlabs.org,
	Linus Torvalds <torvalds@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Random crashes with 2.6.27-rc3 on PPC
Date: Sun, 24 Aug 2008 16:46:38 +0200	[thread overview]
Message-ID: <je7ia6bhdd.fsf@sykes.suse.de> (raw)
In-Reply-To: <200808241544.12412.mb@bu3sch.de> (Michael Buesch's message of "Sun, 24 Aug 2008 15:44:11 +0200")

Michael Buesch <mb@bu3sch.de> writes:

> The following workaround seems to fix the crashes on powerpc.
> However, this patch is clearly not what we want for other architectures,
> as they might need -fno-omit-frame-pointer to function properly.

This has a better chance to be accepted. :-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 8b5a7d3..f9a2e48 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -394,7 +394,7 @@ config LOCKDEP
 	bool
 	depends on DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT
 	select STACKTRACE
-	select FRAME_POINTER if !X86 && !MIPS
+	select FRAME_POINTER if !X86 && !MIPS && !PPC
 	select KALLSYMS
 	select KALLSYMS_ALL
 

> Index: linux-2.6/kernel/Makefile
> ===================================================================
> --- linux-2.6.orig/kernel/Makefile	2008-08-24 11:50:23.000000000 +0200
> +++ linux-2.6/kernel/Makefile	2008-08-24 12:15:54.000000000 +0200
> @@ -92,13 +92,13 @@ obj-$(CONFIG_SMP) += sched_cpupri.o
>  ifneq ($(CONFIG_SCHED_NO_NO_OMIT_FRAME_POINTER),y)
>  # According to Alan Modra <alan@linuxcare.com.au>, the -fno-omit-frame-pointer is
>  # needed for x86 only.  Why this used to be enabled for all architectures is beyond
>  # me.  I suspect most platforms don't need this, but until we know that for sure
>  # I turn this off for IA-64 only.  Andreas Schwab says it's also needed on m68k
>  # to get a correct value for the wait-channel (WCHAN in ps). --davidm
> -CFLAGS_sched.o := $(PROFILING) -fno-omit-frame-pointer
> +CFLAGS_sched.o := $(PROFILING)

CONFIG_SCHED_NO_NO_OMIT_FRAME_POINTER is already enabled on powerpc.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  reply	other threads:[~2008-08-24 14:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-23 14:10 Random crashes with 2.6.27-rc3 on PPC Michael Buesch
2008-08-23 16:58 ` Arnaud Ebalard
2008-08-23 22:52 ` Benjamin Herrenschmidt
2008-08-24  7:23   ` Michael Buesch
2008-08-24 13:44   ` Michael Buesch
2008-08-24 14:46     ` Andreas Schwab [this message]
2008-08-24 15:00       ` Michael Buesch
2008-08-24 22:39       ` Benjamin Herrenschmidt
2008-08-24 22:37     ` Benjamin Herrenschmidt
2008-09-02  6:50       ` [PATCH 1/1] Work around the fomit-frame-pointer bug Tony Breeds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=je7ia6bhdd.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mb@bu3sch.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox