From: Andreas Schwab <schwab@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: WANG Cong <xiyou.wangcong@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-kbuild@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
linux-mips@linux-mips.org
Subject: Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles
Date: Tue, 01 Jan 2008 14:44:48 +0100 [thread overview]
Message-ID: <jefxxhlkxb.fsf@sykes.suse.de> (raw)
In-Reply-To: <20080101101540.GB28913@uranus.ravnborg.org> (Sam Ravnborg's message of "Tue\, 1 Jan 2008 11\:15\:40 +0100")
Sam Ravnborg <sam@ravnborg.org> writes:
>> @@ -24,7 +24,7 @@ HEAD_DEFINES := -D_kernel_start=0x$(KERNEL_START) \
>> -D TIMESTAMP=$(shell date +%s)
>>
>> $(obj)/head.o: $(obj)/head.S $(KERNEL_IMAGE)
>> - $(CC) -fno-pic $(HEAD_DEFINES) -I$(TOPDIR)/include -c -o $@ $<
>> + $(CC) -fno-pic $(HEAD_DEFINES) -I$(objtree)/include -c -o $@ $<
> This has never worked with O=.. builds.
> The correct fix here is to use:
>> + $(CC) -fno-pic $(HEAD_DEFINES) -Iinclude -Iinclude2 -c -o $@ $<
>
> The -Iinclude2 is only for O=... builds so to keep current
> behaviour removing $(TOPDIR)/ would do it.
Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)?
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2008-01-01 13:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-01 7:13 [Patch 0/8] Remove 'TOPDIR' from Makefiles WANG Cong
2008-01-01 7:18 ` [Patch 1/8] UML: " WANG Cong
2008-01-01 10:33 ` Sam Ravnborg
2008-01-01 10:49 ` Sam Ravnborg
2008-01-01 13:01 ` (Try #2) " WANG Cong
2008-01-02 15:02 ` Jeff Dike
2008-01-02 17:27 ` Sam Ravnborg
2008-01-01 7:22 ` [Patch 2/8] MIPS: " WANG Cong
2008-01-01 10:15 ` Sam Ravnborg
2008-01-01 13:11 ` (Try #2) " WANG Cong
2008-01-01 13:44 ` Andreas Schwab [this message]
2008-01-01 17:57 ` Sam Ravnborg
2008-01-02 6:21 ` (Try #3) " WANG Cong
2008-01-02 19:24 ` Sam Ravnborg
2008-01-11 14:17 ` Ralf Baechle
2008-01-11 17:02 ` Sam Ravnborg
2008-01-14 6:26 ` WANG Cong
2008-01-01 7:25 ` [Patch 3/8] S390: " WANG Cong
2008-01-01 10:17 ` Sam Ravnborg
2008-01-01 13:27 ` (Try #2) [Patch 3/8] S390: Tiny fixes for Makefile WANG Cong
2008-01-01 17:42 ` Sam Ravnborg
2008-01-02 6:42 ` (Try #3) [Patch 3/8] S390: Remove 'TOPDIR' from Makefile WANG Cong
2008-01-02 9:31 ` Martin Schwidefsky
2008-01-02 9:49 ` Sam Ravnborg
2008-01-01 7:29 ` [Patch 4/8] CRIS: Remove 'TOPDIR' from Makefiles WANG Cong
2008-01-01 10:20 ` Sam Ravnborg
2008-01-01 13:34 ` (Try #2) " WANG Cong
2008-01-02 6:27 ` (Try #3) " WANG Cong
2008-01-02 19:25 ` Sam Ravnborg
2008-01-03 17:03 ` Jesper Nilsson
2008-01-03 19:59 ` Sam Ravnborg
2008-01-01 7:33 ` [Patch 5/8] INFINIBAND: " WANG Cong
2008-01-01 10:26 ` Sam Ravnborg
2008-01-01 13:41 ` (Try #2) " WANG Cong
2008-01-02 19:26 ` Sam Ravnborg
2008-01-01 7:36 ` [Patch 6/8] FRV: " WANG Cong
2008-01-01 10:27 ` Sam Ravnborg
2008-01-01 14:00 ` (Try #2) [Patch 6/8] FRV: Drop " WANG Cong
2008-01-02 19:26 ` Sam Ravnborg
2008-01-01 7:41 ` [Patch 7/8] FS: Remove " WANG Cong
2008-01-01 10:30 ` Sam Ravnborg
2008-01-01 14:28 ` (Try #2) [Patch 7/8] FS: Drop 'TOPDIR' from Makefiles and remove some dead code WANG Cong
2008-01-02 19:27 ` Sam Ravnborg
2008-01-01 17:27 ` [xfs-masters] [Patch 7/8] FS: Remove 'TOPDIR' from Makefiles Eric Sandeen
2008-01-01 17:37 ` Sam Ravnborg
2008-01-02 5:55 ` (Try #3) [Patch 7/8] FS: Remove dead code WANG Cong
2008-01-01 7:43 ` [Patch 8/8] Remove 'TOPDIR' from the Top Makefile WANG Cong
2008-01-01 10:09 ` [Patch 0/8] Remove 'TOPDIR' from Makefiles Sam Ravnborg
2008-01-02 9:51 ` Sam Ravnborg
2008-01-03 4:37 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jefxxhlkxb.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sam@ravnborg.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).