public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, Zachary Amsden <zach@vmware.com>,
	Uwe Zeisberger <zeisberg@informatik.uni-freiburg.de>,
	Russell King <rmk@arm.linux.org.uk>
Subject: Re: [PATCH] Kbuild fixes
Date: Thu, 01 Dec 2005 17:25:00 +0100	[thread overview]
Message-ID: <jehd9s6azn.fsf@sykes.suse.de> (raw)
In-Reply-To: <20051110213640.GA19831@mars.ravnborg.org> (Sam Ravnborg's message of "Thu, 10 Nov 2005 22:36:40 +0100")

Sam Ravnborg <sam@ravnborg.org> writes:

> Author: Uwe Zeisberger <zeisberg@informatik.uni-freiburg.de>
>
>     [PATCH] kbuild: make kernelrelease in unconfigured kernel prints an error
>     
>     Do not include .config for target kernelrelease

This is wrong.  KERNELRELEASE depends on CONFIG_LOCALVERSION, thus you
need .config.

Signed-off-by: Andreas Schwab <schwab@suse.de>

Index: linux-2.6.14/Makefile
===================================================================
--- linux-2.6.14.orig/Makefile	2005-12-01 17:10:33.998015103 +0100
+++ linux-2.6.14/Makefile	2005-12-01 17:11:39.605921389 +0100
@@ -412,7 +412,7 @@ outputmakefile:
 # of make so .config is not included in this case either (for *config).
 
 no-dot-config-targets := clean mrproper distclean \
-			 cscope TAGS tags help %docs check% kernelrelease
+			 cscope TAGS tags help %docs check%
 
 config-targets := 0
 mixed-targets  := 0

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  parent reply	other threads:[~2005-12-01 16:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-10 21:36 [PATCH] Kbuild fixes Sam Ravnborg
2005-11-10 21:46 ` Linus Torvalds
2005-11-10 22:16   ` Sam Ravnborg
2005-12-01 16:25 ` Andreas Schwab [this message]
2005-12-02  7:28   ` Uwe Zeisberger
  -- strict thread matches above, loose matches on Subject: below --
2006-08-01  9:40 [PATCH] kbuild fixes Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jehd9s6azn.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=sam@ravnborg.org \
    --cc=torvalds@osdl.org \
    --cc=zach@vmware.com \
    --cc=zeisberg@informatik.uni-freiburg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox