From: Andreas Schwab <schwab@suse.de>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] add prink KERN_* suffixes
Date: Thu, 13 Mar 2003 18:22:33 +0100 [thread overview]
Message-ID: <jellzji3l2.fsf@sykes.suse.de> (raw)
In-Reply-To: <20030313164157.GB6435@renditai.milesteg.arr> (Daniele Venzano's message of "Thu, 13 Mar 2003 17:41:57 +0100")
Daniele Venzano <webvenza@libero.it> writes:
|> diff -urN -X /home/venza/kernel/dontdiff linux-2.5.64/drivers/net/3c509.c linux-2.5.64-work/drivers/net/3c509.c
|> --- linux-2.5.64/drivers/net/3c509.c 2003-03-06 11:41:18.000000000 +0100
|> +++ linux-2.5.64-work/drivers/net/3c509.c 2003-03-13 12:28:39.000000000 +0100
|> @@ -316,14 +316,14 @@
|>
|> {
|> const char *if_names[] = {"10baseT", "AUI", "undefined", "BNC"};
|> - printk("%s: 3c5x9 at %#3.3lx, %s port, address ",
|> + printk(KERN_INFO "%s: 3c5x9 at %#3.3lx, %s port, address ",
|> dev->name, dev->base_addr, if_names[(dev->if_port & 0x03)]);
|> }
|>
|> /* Read in the station address. */
|> for (i = 0; i < 6; i++)
|> - printk(" %2.2x", dev->dev_addr[i]);
|> - printk(", IRQ %d.\n", dev->irq);
|> + printk(KERN_INFO " %2.2x", dev->dev_addr[i]);
|> + printk(KERN_INFO ", IRQ %d.\n", dev->irq);
This is wrong, a KERN_* prefix is only recognized after a newline.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2003-03-13 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-13 16:41 [PATCH] add prink KERN_* suffixes Daniele Venzano
2003-03-13 17:22 ` Andreas Schwab [this message]
2003-03-13 21:43 ` Robert Love
2003-03-14 18:45 ` Daniele Venzano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jellzji3l2.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox