Re: Help with compiler warning

[Andreas Schwab <schwab@suse.de>]

Larry Finger <Larry.Finger@lwfinger.net> writes:

> Benny Halevy wrote:
>> On Aug. 24, 2008, 18:29 +0300, Benny Halevy <bhalevy@panasas.com> wrote:
>>> On Aug. 22, 2008, 4:36 +0300, Larry Finger <Larry.Finger@lwfinger.net> wrote:
>>>> In drivers/pcmcia/cardbus.c, the following statement
>>>>
>>>>          memcpy_fromio(ptr, s->cb_cis_virt + addr, len);
>>>>
>>>> generates the warning
>>>>
>>>>    CC [M]  drivers/pcmcia/cardbus.o
>>>> include/asm/io_32.h: In function ‘memcpy_fromio’:
>>>> include/asm/io_32.h:151: warning: passing argument 2 of ‘__memcpy’
>>>> discards qualifiers from pointer target type
>>>>
>>>> s->cb_cis_virt is "void __iomem" and addr is uint.
>>>>
>>>> What cast does argument 2 need to silence the warning?

The cast needs to be in memcpy_fromio, but there is already one, so why
do you get a warning in the first place?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."