From: Andreas Schwab <schwab@suse.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/cdrom/gscd.c: kill dead code
Date: Tue, 22 Mar 2005 23:46:20 +0100 [thread overview]
Message-ID: <jemzsvb8oz.fsf@sykes.suse.de> (raw)
In-Reply-To: <20050322215505.GN1948@stusta.de> (Adrian Bunk's message of "Tue, 22 Mar 2005 22:55:05 +0100")
Adrian Bunk <bunk@stusta.de> writes:
> This patch removes some obviously dead code found by the Coverity
> checker.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.12-rc1-mm1-full/drivers/cdrom/gscd.c.old 2005-03-22 20:58:54.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/drivers/cdrom/gscd.c 2005-03-22 20:59:46.000000000 +0100
> @@ -694,12 +694,8 @@
> do {
> result = wait_drv_ready();
> } while (result != 6 || result == 0x0E);
>
> - if (result != 6) {
> - cmd_end();
> - return;
> - }
I'd rather guess that (result != 6 || result == 0x0E) is borken, since
it's equivalent to (result != 6).
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2005-03-22 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-22 21:55 [2.6 patch] drivers/cdrom/gscd.c: kill dead code Adrian Bunk
2005-03-22 22:46 ` Andreas Schwab [this message]
2005-03-23 23:54 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jemzsvb8oz.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox