From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262029AbUFEVXe (ORCPT ); Sat, 5 Jun 2004 17:23:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262045AbUFEVXe (ORCPT ); Sat, 5 Jun 2004 17:23:34 -0400 Received: from cantor.suse.de ([195.135.220.2]:6351 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S262029AbUFEVXd (ORCPT ); Sat, 5 Jun 2004 17:23:33 -0400 To: "David S. Miller" Cc: olh@suse.de, linux-kernel@vger.kernel.org, netdev@oss.sgi.com Subject: Re: [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing References: <20040605204334.GA1134@suse.de> <20040605140153.6c5945a0.davem@redhat.com> <20040605140544.0de4034d.davem@redhat.com> From: Andreas Schwab X-Yow: It's the RINSE CYCLE!! They've ALL IGNORED the RINSE CYCLE!! Date: Sat, 05 Jun 2004 23:21:53 +0200 In-Reply-To: <20040605140544.0de4034d.davem@redhat.com> (David S. Miller's message of "Sat, 5 Jun 2004 14:05:44 -0700") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org "David S. Miller" writes: > This means also that Olaf's patch is broken, when CONFIG_COMPAT is not > set, MSG_CMSG_COMPAT is zero, thus ~MSG_CMSG_COMPAT is the unexpected > value all 1's thus breaking the tests for unexpected flags completely. ??? Where do you get ~MSG_CMSG_COMPAT from? Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."