public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: David Miller <davem@davemloft.net>
Cc: paulus@samba.org, akpm@linux-foundation.org, lkml@davidb.org,
	linux-kernel@vger.kernel.org, drepper@redhat.com,
	mtk-manpages@gmx.net
Subject: Re: compat_sys_times() bogus until jiffies >= 0.
Date: Thu, 08 Nov 2007 11:20:17 +0100	[thread overview]
Message-ID: <jetznxt4wu.fsf@sykes.suse.de> (raw)
In-Reply-To: <20071107.180918.263752219.davem@davemloft.net> (David Miller's message of "Wed\, 07 Nov 2007 18\:09\:18 -0800 \(PST\)")

David Miller <davem@davemloft.net> writes:

> I agree with this analysis.
>
> The Linux man page for times() explicitly lists (clock_t) -1 as a
> return value meaning error.
>
> So even if we did make some effort to return errors "properly" (via
> force_successful_syscall_return() et al.) userspace would still be
> screwed because (clock_t) -1 would be interpreted as an error.
>
> Actually I think this basically proves we cannot return (clock_t) -1
> ever because all existing userland (I'm not talking about inside
> glibc, I'm talking about inside of applications) will see this as an
> error.
>
> User applications have no other way to check for error.
>
> This API is definitely very poorly designed, no matter which way we
> "fix" this some case will remain broken.

A possible remedy is to return the ticks since process start time, which
delays the wrap around much further.  POSIX only demands consistency
within the same process.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  reply	other threads:[~2007-11-08 10:20 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 22:47 compat_sys_times() bogus until jiffies >= 0 David Brown
2007-11-07 23:28 ` Andrew Morton
2007-11-08  0:18   ` Andrew Morton
2007-11-08  0:54     ` Andreas Schwab
2007-11-08  1:17       ` Andrew Morton
2007-11-08  1:53     ` Paul Mackerras
2007-11-08  2:09       ` David Miller
2007-11-08 10:20         ` Andreas Schwab [this message]
2007-11-08 14:42           ` Chris Friesen
2007-11-09 18:20             ` Ulrich Drepper
2007-12-20 11:36               ` Michael Kerrisk
2007-12-20 11:51                 ` David Miller
2007-12-22  0:42                   ` Andi Kleen
2007-12-22  1:41                     ` David Miller
2007-12-22  1:45                       ` David Miller
2007-12-22  1:53                         ` Andi Kleen
2007-12-22  4:36                           ` David Miller
2007-12-22 12:47                             ` Andi Kleen
2007-12-22  1:49                       ` Andi Kleen
2007-11-08 19:25         ` Denys Vlasenko
2007-11-08  3:07       ` Andrew Morton
2007-11-08  3:13         ` David Miller
2007-11-08  5:15           ` Paul Mackerras
2007-11-08  6:24             ` David Miller
2007-11-08  4:59         ` Paul Mackerras
2007-11-08  5:20           ` Andrew Morton
2007-11-08  5:36             ` Paul Mackerras
2007-11-08  6:12               ` Andrew Morton
2007-11-08  6:25             ` David Miller
2007-11-08  7:09               ` Andrew Morton
2007-11-08  7:14                 ` David Miller
2007-11-08  8:53               ` Paul Mackerras
2007-11-08  6:22           ` David Miller
2007-11-08 19:27         ` Denys Vlasenko
2007-11-08  0:50   ` David Miller
2007-11-08  1:13     ` Andrew Morton
2007-11-08  6:00   ` David Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jetznxt4wu.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=drepper@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@davidb.org \
    --cc=mtk-manpages@gmx.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox