From: Andreas Schwab <schwab@suse.de>
To: Jan Kasprzak <kas@fi.muni.cz>
Cc: Arnd Bergmann <arnd@arndb.de>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cosa.h ioctl numbers
Date: Thu, 02 Dec 2004 14:57:43 +0100 [thread overview]
Message-ID: <jeu0r4ajl4.fsf@sykes.suse.de> (raw)
In-Reply-To: <20041202131224.GI11992@fi.muni.cz> (Jan Kasprzak's message of "Thu, 2 Dec 2004 14:12:25 +0100")
Jan Kasprzak <kas@fi.muni.cz> writes:
> Arnd Bergmann wrote:
> : > /* Write the block to the device memory (i.e. download the microcode) */
> : > -#define COSAIODOWNLD _IOW('C',0xf2, struct cosa_download)
> : > +#define COSAIODOWNLD _IOW('C',0xf2, struct cosa_download *)
> :
> : Isn't that rather misleading? I suppose the real argument is
> : 'struct cosa_download', so you should have some kind of comment there,
> : e.g.
> :
> : #define COSAIODOWNLD _IOW('C',0xf2, long) /* actually struct cosa_download */
>
> Well, the third argument of ioctl(2) is of type
> struct cosa_download *.
>
> OK, second try with comments added.
If you want real compatibility you should use size_t, which is what 2.4 is
effectively using.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2004-12-02 13:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-02 12:44 [PATCH] cosa.h ioctl numbers Jan Kasprzak
2004-12-02 12:58 ` Arnd Bergmann
2004-12-02 13:12 ` Jan Kasprzak
2004-12-02 13:57 ` Andreas Schwab [this message]
2004-12-02 14:11 ` Jan Kasprzak
2004-12-02 15:13 ` Andreas Schwab
2004-12-02 15:50 ` Linus Torvalds
2005-01-06 10:02 ` Jan Kasprzak
2004-12-02 15:56 ` Jan Kasprzak
2004-12-02 16:45 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jeu0r4ajl4.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=arnd@arndb.de \
--cc=kas@fi.muni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox