From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9719CC43331 for ; Thu, 18 Feb 2021 19:34:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EAD464E22 for ; Thu, 18 Feb 2021 19:34:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232452AbhBRTd1 (ORCPT ); Thu, 18 Feb 2021 14:33:27 -0500 Received: from foss.arm.com ([217.140.110.172]:54422 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233380AbhBRSwY (ORCPT ); Thu, 18 Feb 2021 13:52:24 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8D7A21FB; Thu, 18 Feb 2021 10:51:37 -0800 (PST) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3957A3F694; Thu, 18 Feb 2021 10:51:36 -0800 (PST) From: Valentin Schneider To: Lingutla Chandrasekhar , linux-kernel@vger.kernel.org Cc: juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, pkondeti@codeaurora.org, peterz@infradead.org, mingo@kernel.org, Lingutla Chandrasekhar Subject: Re: [PATCH] sched/fair: Ignore percpu threads for imbalance pulls In-Reply-To: References: <20210217120854.1280-1-clingutla@codeaurora.org> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Thu, 18 Feb 2021 18:51:24 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/02/21 14:50, Valentin Schneider wrote: > @@ -7539,6 +7539,9 @@ int can_migrate_task(struct task_struct *p, struct lb_env *env) > if (throttled_lb_pair(task_group(p), env->src_cpu, env->dst_cpu)) > return 0; > > + if (kthread_is_per_cpu(p)) > + return 0; > + That's missing a (p->flags & PF_KTHREAD), but you get the idea...