public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Valentin Schneider <valentin.schneider@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>
Subject: Re: linux-next: Tree for Sep 8 (sched/topology.c)
Date: Tue, 08 Sep 2020 16:47:07 +0100	[thread overview]
Message-ID: <jhj4ko86zk4.mognet@arm.com> (raw)
In-Reply-To: <CAKfTPtB-br6iKAMnofbPEmPVF-fpQpjkbXtfTcNkNzbc1Kdtug@mail.gmail.com>


On 08/09/20 16:03, Vincent Guittot wrote:
> Adding Valentin as this seems related to the patch "sched/topology:
> Move sd_flag_debug out of linux/sched/topology.h"
>

Thanks!

>
> On Tue, 8 Sep 2020 at 16:48, Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 9/8/20 3:56 AM, Stephen Rothwell wrote:
>> > Hi all,
>> >
>> > Changes since 20200903:
>> >
>>
>> on i386:
>>
>> ld: kernel/sched/topology.o: in function `cpu_attach_domain':
>> topology.c:(.text+0xf03): undefined reference to `sd_flag_debug'
>> ld: topology.c:(.text+0xf4f): undefined reference to `sd_flag_debug'
>> ld: topology.c:(.text+0xfc2): undefined reference to `sd_flag_debug'
>>

So that should be in sched_domain_debug_one() which only gets defined for
CONFIG_SCHED_DEBUG. Now, sd_flag_debug is:
- declared in include/linux/sched/topology.h if CONFIG_SCHED_DEBUG
- defined in kernel/sched/debug.c (only built if CONFIG_SCHED_DEBUG)

I've compile-tested this for arm64 & x86 (default configs + toggling
CONFIG_SCHED_DEBUG). UP can't be the cause because topology.c wouldn't even
be compiled then.

IIUC this is a build with CONFIG_SCHED_DEBUG but for some reason it doesn't
link with kernel/sched/debug.o?

>>
>> Full randconfig file is attached.
>>

I wanted to peek at that config, but can't find that email. The thread view
on lore [1] also shows it as AWOL; any chance you (or someone else) could
re-send it?

[1]: https://lore.kernel.org/lkml/20200908205659.361b0a1b@canb.auug.org.au/

>>
>> --
>> ~Randy
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>

  reply	other threads:[~2020-09-08 15:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08 10:56 linux-next: Tree for Sep 8 Stephen Rothwell
2020-09-08 14:47 ` linux-next: Tree for Sep 8 (sched/topology.c) Randy Dunlap
2020-09-08 15:03   ` Vincent Guittot
2020-09-08 15:47     ` Valentin Schneider [this message]
2020-09-08 15:50       ` Randy Dunlap
2020-09-08 16:07         ` Valentin Schneider
2020-09-08 16:28           ` Valentin Schneider
2020-09-08 17:17             ` Randy Dunlap
2020-09-08 16:25 ` linux-next: Tree for Sep 8 (net/ipv4/ip_tunnel.o) Randy Dunlap
2020-09-08 17:12 ` linux-next: Tree for Sep 8 (drivers/mmc/host/meson-gx-mmc.o) Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jhj4ko86zk4.mognet@arm.com \
    --to=valentin.schneider@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox