From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A79CC2D0E2 for ; Tue, 8 Sep 2020 15:55:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4BDD251E3 for ; Tue, 8 Sep 2020 15:55:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730755AbgIHPuu (ORCPT ); Tue, 8 Sep 2020 11:50:50 -0400 Received: from foss.arm.com ([217.140.110.172]:56262 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730670AbgIHPtM (ORCPT ); Tue, 8 Sep 2020 11:49:12 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2853E1045; Tue, 8 Sep 2020 08:47:15 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0BD343F66E; Tue, 8 Sep 2020 08:47:13 -0700 (PDT) References: <20200908205659.361b0a1b@canb.auug.org.au> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Vincent Guittot Cc: Randy Dunlap , Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Ingo Molnar , Peter Zijlstra , Juri Lelli Subject: Re: linux-next: Tree for Sep 8 (sched/topology.c) In-reply-to: Date: Tue, 08 Sep 2020 16:47:07 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/09/20 16:03, Vincent Guittot wrote: > Adding Valentin as this seems related to the patch "sched/topology: > Move sd_flag_debug out of linux/sched/topology.h" > Thanks! > > On Tue, 8 Sep 2020 at 16:48, Randy Dunlap wrote: >> >> On 9/8/20 3:56 AM, Stephen Rothwell wrote: >> > Hi all, >> > >> > Changes since 20200903: >> > >> >> on i386: >> >> ld: kernel/sched/topology.o: in function `cpu_attach_domain': >> topology.c:(.text+0xf03): undefined reference to `sd_flag_debug' >> ld: topology.c:(.text+0xf4f): undefined reference to `sd_flag_debug' >> ld: topology.c:(.text+0xfc2): undefined reference to `sd_flag_debug' >> So that should be in sched_domain_debug_one() which only gets defined for CONFIG_SCHED_DEBUG. Now, sd_flag_debug is: - declared in include/linux/sched/topology.h if CONFIG_SCHED_DEBUG - defined in kernel/sched/debug.c (only built if CONFIG_SCHED_DEBUG) I've compile-tested this for arm64 & x86 (default configs + toggling CONFIG_SCHED_DEBUG). UP can't be the cause because topology.c wouldn't even be compiled then. IIUC this is a build with CONFIG_SCHED_DEBUG but for some reason it doesn't link with kernel/sched/debug.o? >> >> Full randconfig file is attached. >> I wanted to peek at that config, but can't find that email. The thread view on lore [1] also shows it as AWOL; any chance you (or someone else) could re-send it? [1]: https://lore.kernel.org/lkml/20200908205659.361b0a1b@canb.auug.org.au/ >> >> -- >> ~Randy >> Reported-by: Randy Dunlap