From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23CC1C433DF for ; Thu, 2 Jul 2020 14:33:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02BD920890 for ; Thu, 2 Jul 2020 14:33:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729818AbgGBOdB (ORCPT ); Thu, 2 Jul 2020 10:33:01 -0400 Received: from foss.arm.com ([217.140.110.172]:58042 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728179AbgGBOdB (ORCPT ); Thu, 2 Jul 2020 10:33:01 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CCF8531B; Thu, 2 Jul 2020 07:33:00 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E25243F68F; Thu, 2 Jul 2020 07:32:59 -0700 (PDT) References: <20200701190656.10126-1-valentin.schneider@arm.com> <20200701190656.10126-4-valentin.schneider@arm.com> <20200702142042.GI4817@hirez.programming.kicks-ass.net> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, morten.rasmussen@arm.com Subject: Re: [PATCH v3 3/7] sched/topology: Verify SD_* flags setup when sched_debug is on In-reply-to: <20200702142042.GI4817@hirez.programming.kicks-ass.net> Date: Thu, 02 Jul 2020 15:32:57 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/07/20 15:20, Peter Zijlstra wrote: > On Wed, Jul 01, 2020 at 08:06:51PM +0100, Valentin Schneider wrote: > >> @@ -29,6 +29,7 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level, >> struct cpumask *groupmask) >> { >> struct sched_group *group = sd->groups; >> + int flags = sd->flags; > > unsigned long flags = sd->flags; > >> >> cpumask_clear(groupmask); >> >> @@ -43,6 +44,22 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level, >> printk(KERN_ERR "ERROR: domain->groups does not contain CPU%d\n", cpu); >> } >> >> + for (; flags; flags &= flags - 1) { >> + unsigned int idx = __ffs(flags); > > for_each_set_bit(idx, &flags, SD_MAX_BIT) { > > Yes, it's a bit yuck, but far more readable imo. > Much better than homegrown stuff, thanks! >> + unsigned int flag = BIT(idx); >> + unsigned int meta_flags = sd_flag_debug[idx].meta_flags; >> + >> + if ((meta_flags & SDF_SHARED_CHILD) && sd->child && >> + !(sd->child->flags & flag)) >> + printk(KERN_ERR "ERROR: flag %s set here but not in child\n", >> + sd_flag_debug[idx].name); >> + >> + if ((meta_flags & SDF_SHARED_PARENT) && sd->parent && >> + !(sd->parent->flags & flag)) >> + printk(KERN_ERR "ERROR: flag %s set here but not in parent\n", >> + sd_flag_debug[idx].name); >> + } >> + >> printk(KERN_DEBUG "%*s groups:", level + 1, ""); >> do { >> if (!group) { >> -- >> 2.27.0 >>