linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] i2c: s3c2410: Drop S3C2410 OF support
@ 2025-08-30 10:36 Krzysztof Kozlowski
  2025-08-30 10:36 ` [PATCH 2/2] dt-bindings: i2c: samsung,s3c2410-i2c: Drop S3C2410 Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-30 10:36 UTC (permalink / raw)
  To: Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Alim Akhtar, linux-i2c, devicetree, linux-kernel,
	linux-arm-kernel, linux-samsung-soc
  Cc: Krzysztof Kozlowski

Samsung S3C2410 SoC was removed from the Linux kernel in the
commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support"), in January
2023.  There are no in-kernel users of "samsung,s3c2410-i2c" compatible.

However, there is still a user of "s3c2410-i2c" platform device ID,
S3C64xx platform, so that part needs to stay.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/i2c/busses/i2c-s3c2410.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index f4fa4703acbd..8138f5ef40f0 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -138,7 +138,6 @@ static void i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
 
 #ifdef CONFIG_OF
 static const struct of_device_id s3c24xx_i2c_match[] = {
-	{ .compatible = "samsung,s3c2410-i2c", .data = (void *)0 },
 	{ .compatible = "samsung,s3c2440-i2c", .data = (void *)QUIRK_S3C2440 },
 	{ .compatible = "samsung,s3c2440-hdmiphy-i2c",
 	  .data = (void *)(QUIRK_S3C2440 | QUIRK_HDMIPHY | QUIRK_NO_GPIO) },
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] dt-bindings: i2c: samsung,s3c2410-i2c: Drop S3C2410
  2025-08-30 10:36 [PATCH 1/2] i2c: s3c2410: Drop S3C2410 OF support Krzysztof Kozlowski
@ 2025-08-30 10:36 ` Krzysztof Kozlowski
  2025-09-01 20:13   ` Rob Herring (Arm)
  2025-09-03 10:32 ` [PATCH 1/2] i2c: s3c2410: Drop S3C2410 OF support Andi Shyti
  2025-09-03 10:37 ` Andi Shyti
  2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-30 10:36 UTC (permalink / raw)
  To: Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Alim Akhtar, linux-i2c, devicetree, linux-kernel,
	linux-arm-kernel, linux-samsung-soc
  Cc: Krzysztof Kozlowski

Samsung S3C2410 SoC was removed from the Linux kernel in the
commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support"), in January
2023.  There are no in-kernel users of "samsung,s3c2410-i2c" compatible.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
index 6ba7d793504c..a2ddc6803617 100644
--- a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
@@ -13,7 +13,6 @@ properties:
   compatible:
     oneOf:
       - enum:
-          - samsung,s3c2410-i2c
           - samsung,s3c2440-i2c
             # For s3c2440-like I2C used inside HDMIPHY block found on several SoCs:
           - samsung,s3c2440-hdmiphy-i2c
@@ -93,7 +92,6 @@ allOf:
         compatible:
           contains:
             enum:
-              - samsung,s3c2410-i2c
               - samsung,s3c2440-i2c
               - samsung,s3c2440-hdmiphy-i2c
     then:
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] dt-bindings: i2c: samsung,s3c2410-i2c: Drop S3C2410
  2025-08-30 10:36 ` [PATCH 2/2] dt-bindings: i2c: samsung,s3c2410-i2c: Drop S3C2410 Krzysztof Kozlowski
@ 2025-09-01 20:13   ` Rob Herring (Arm)
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring (Arm) @ 2025-09-01 20:13 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Conor Dooley, linux-samsung-soc, devicetree, linux-arm-kernel,
	Krzysztof Kozlowski, linux-i2c, linux-kernel, Alim Akhtar,
	Andi Shyti


On Sat, 30 Aug 2025 12:36:03 +0200, Krzysztof Kozlowski wrote:
> Samsung S3C2410 SoC was removed from the Linux kernel in the
> commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support"), in January
> 2023.  There are no in-kernel users of "samsung,s3c2410-i2c" compatible.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml | 2 --
>  1 file changed, 2 deletions(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] i2c: s3c2410: Drop S3C2410 OF support
  2025-08-30 10:36 [PATCH 1/2] i2c: s3c2410: Drop S3C2410 OF support Krzysztof Kozlowski
  2025-08-30 10:36 ` [PATCH 2/2] dt-bindings: i2c: samsung,s3c2410-i2c: Drop S3C2410 Krzysztof Kozlowski
@ 2025-09-03 10:32 ` Andi Shyti
  2025-09-03 10:37 ` Andi Shyti
  2 siblings, 0 replies; 5+ messages in thread
From: Andi Shyti @ 2025-09-03 10:32 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
	linux-i2c, devicetree, linux-kernel, linux-arm-kernel,
	linux-samsung-soc

Hi Krzysztof,

On Sat, Aug 30, 2025 at 12:36:02PM +0200, Krzysztof Kozlowski wrote:
> Samsung S3C2410 SoC was removed from the Linux kernel in the
> commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support"), in January
> 2023.  There are no in-kernel users of "samsung,s3c2410-i2c" compatible.
> 
> However, there is still a user of "s3c2410-i2c" platform device ID,
> S3C64xx platform, so that part needs to stay.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

As an ex-Samsung active developer (and always hoping to be back
someday):

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Thanks,
Andi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] i2c: s3c2410: Drop S3C2410 OF support
  2025-08-30 10:36 [PATCH 1/2] i2c: s3c2410: Drop S3C2410 OF support Krzysztof Kozlowski
  2025-08-30 10:36 ` [PATCH 2/2] dt-bindings: i2c: samsung,s3c2410-i2c: Drop S3C2410 Krzysztof Kozlowski
  2025-09-03 10:32 ` [PATCH 1/2] i2c: s3c2410: Drop S3C2410 OF support Andi Shyti
@ 2025-09-03 10:37 ` Andi Shyti
  2 siblings, 0 replies; 5+ messages in thread
From: Andi Shyti @ 2025-09-03 10:37 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
	linux-i2c, devicetree, linux-kernel, linux-arm-kernel,
	linux-samsung-soc

Hi Krzysztof,

On Sat, Aug 30, 2025 at 12:36:02PM +0200, Krzysztof Kozlowski wrote:
> Samsung S3C2410 SoC was removed from the Linux kernel in the
> commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support"), in January
> 2023.  There are no in-kernel users of "samsung,s3c2410-i2c" compatible.
> 
> However, there is still a user of "s3c2410-i2c" platform device ID,
> S3C64xx platform, so that part needs to stay.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

both patches reviewed and merged to i2c/i2c-host.

Thanks,
Andi

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-09-03 10:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-30 10:36 [PATCH 1/2] i2c: s3c2410: Drop S3C2410 OF support Krzysztof Kozlowski
2025-08-30 10:36 ` [PATCH 2/2] dt-bindings: i2c: samsung,s3c2410-i2c: Drop S3C2410 Krzysztof Kozlowski
2025-09-01 20:13   ` Rob Herring (Arm)
2025-09-03 10:32 ` [PATCH 1/2] i2c: s3c2410: Drop S3C2410 OF support Andi Shyti
2025-09-03 10:37 ` Andi Shyti

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).