From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752480AbcF1UiF (ORCPT ); Tue, 28 Jun 2016 16:38:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55224 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751952AbcF1UiE (ORCPT ); Tue, 28 Jun 2016 16:38:04 -0400 From: Bandan Das To: Paolo Bonzini Cc: kvm@vger.kernel.org, guangrong.xiao@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] mmu: mark spte present if the x bit is set References: <1467088360-10186-1-git-send-email-bsd@redhat.com> <1467088360-10186-2-git-send-email-bsd@redhat.com> <55601232-c941-74e8-f740-fd09e9e8a6ae@redhat.com> Date: Tue, 28 Jun 2016 16:37:59 -0400 In-Reply-To: (Paolo Bonzini's message of "Tue, 28 Jun 2016 22:17:54 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 28 Jun 2016 20:38:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paolo Bonzini writes: > On 28/06/2016 19:33, Bandan Das wrote: >>>> >> static int is_shadow_present_pte(u64 pte) >>>> >> { >>>> >> - return pte & PT_PRESENT_MASK && !is_mmio_spte(pte); >>>> >> + return pte & (PT_PRESENT_MASK | shadow_x_mask) && >>>> >> + !is_mmio_spte(pte); >>> > >>> > This should really be pte & 7 when using EPT. But this is okay as an >>> > alternative to a new shadow_present_mask. >> I could revive shadow_xonly_valid probably... Anyway, for now I will >> add a TODO comment here. > > It's okay to it like this, because the only invalid PTEs reaching this > point are those that is_mmio_spte filters away. Hence you'll never get > -W- PTEs here, and pte & 7 is really the same as how you wrote it. It's > pretty clever, and doesn't need a TODO at all. :) Thanks, understood. So, the way it is written now covers all cases for pte & 7. Let's still add a comment - clever things are usually confusing to many! > Paolo