From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754508AbcFPWBr (ORCPT ); Thu, 16 Jun 2016 18:01:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47419 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113AbcFPWBq (ORCPT ); Thu, 16 Jun 2016 18:01:46 -0400 From: Bandan Das To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, rkrcmar@redhat.com Subject: Re: [RFC PATCH 2/2] KVM: x86: use __kvm_guest_exit References: <1466065297-4644-1-git-send-email-pbonzini@redhat.com> <1466065297-4644-3-git-send-email-pbonzini@redhat.com> Date: Thu, 16 Jun 2016 18:01:44 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 16 Jun 2016 22:01:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... > static bool vmx_has_high_real_mode_segbase(void) > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 7e3041ef050f..cc741b68139c 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -6706,21 +6706,13 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu) > > kvm_put_guest_xcr0(vcpu); > > - /* Interrupt is enabled by handle_external_intr() */ > kvm_x86_ops->handle_external_intr(vcpu); > > ++vcpu->stat.exits; > > - /* > - * We must have an instruction between local_irq_enable() and > - * kvm_guest_exit(), so the timer interrupt isn't delayed by > - * the interrupt shadow. The stat.exits increment will do nicely. > - * But we need to prevent reordering, hence this barrier(): > - */ > - barrier(); > - > - kvm_guest_exit(); > + __kvm_guest_exit(); kvm_guest_exit has no more callers and so can be removed. Bandan > + local_irq_enable(); > preempt_enable(); > > vcpu->srcu_idx = srcu_read_lock(&vcpu->kvm->srcu);