From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934905AbdBQRW2 (ORCPT ); Fri, 17 Feb 2017 12:22:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47616 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934360AbdBQRW0 (ORCPT ); Fri, 17 Feb 2017 12:22:26 -0500 From: Bandan Das To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls References: <1487169866-14989-1-git-send-email-pbonzini@redhat.com> <372283237.23068299.1487320918001.JavaMail.zimbra@redhat.com> Date: Fri, 17 Feb 2017 12:22:14 -0500 In-Reply-To: <372283237.23068299.1487320918001.JavaMail.zimbra@redhat.com> (Paolo Bonzini's message of "Fri, 17 Feb 2017 03:41:58 -0500 (EST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 17 Feb 2017 17:22:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paolo Bonzini writes: > ----- Original Message ----- >> From: "Bandan Das" >> To: "Paolo Bonzini" >> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org >> Sent: Friday, February 17, 2017 1:04:14 AM >> Subject: Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls >> >> Paolo Bonzini writes: >> >> > Signed-off-by: Paolo Bonzini >> > --- >> >> I took a quick look and found these two potential >> consumers of these set/clear wrappers. >> >> vmcs_set_secondary_exec_control() >> vmx_set_virtual_x2apic_mode() >> >> Since this has been reviewed already, >> we can just have them later in a follow up >> (unless you left them out intentionally). > > Both of these can both set and clear bits, so they could be the > consumer of a new function > > void vmcs_write_bits(u16 field, u32 value, u32 mask) > > but I don't see much benefit in introducing it; the cognitive > load is higher than vmcs_{set,clear}_bits. Yes, agreed. Thanks! > Paolo