From: Bandan Das <bsd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, rkrcmar@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] nvmx: check for shadow vmcs check on entry
Date: Fri, 22 Jul 2016 11:51:44 -0400 [thread overview]
Message-ID: <jpgwpkdd627.fsf@linux.bootlegged.copy> (raw)
In-Reply-To: <266030483.9634373.1469176855327.JavaMail.zimbra@redhat.com> (Paolo Bonzini's message of "Fri, 22 Jul 2016 04:40:55 -0400 (EDT)")
Paolo Bonzini <pbonzini@redhat.com> writes:
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>> > On 21/07/2016 00:25, Bandan Das wrote:
>> >> vmentry should check whether the vmcs provided by
>> >> the guest hypervisor is a shadow vmcs and fail.
>> >
>> > How can this happen, since vmptrld checks the revision_id as you said
>> > below?
>>
>> This is more of a change that adheres to the spec
>> (26.1 Basic VM-Entry Checks); the failure path
>> is slightly different compared to vmptrld though.
>> It's small and harmless but I am ok if you prefer dropping it.
>
> Do you mean that this could happen if the VMCS is modified by L1
> after VMPTRLD? That makes sense, but with David Matlack's change
Yeah that's the only way I can see it happen. If there's a separate path
that takes care of this, should I drop this one ?
> to cache the VMCS it wouldn't be possible to trigger it anymore.
>
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-07-22 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 22:25 [PATCH 0/4] vmx: miscellaneous cleanups Bandan Das
2016-07-20 22:25 ` [PATCH 1/4] nvmx: use warn_on for buggy cases when emulating invept/invvpid Bandan Das
2016-07-21 9:13 ` Paolo Bonzini
2016-07-21 19:18 ` Bandan Das
2016-07-20 22:25 ` [PATCH 2/4] nvmx: mark ept single context invalidation as supported Bandan Das
2016-07-20 22:25 ` [PATCH 3/4] mmu: don't pass *kvm to spte_write_protect Bandan Das
2016-07-21 9:15 ` Paolo Bonzini
2016-07-21 19:21 ` Bandan Das
2016-07-20 22:25 ` [PATCH 4/4] nvmx: check for shadow vmcs check on entry Bandan Das
2016-07-21 9:16 ` Paolo Bonzini
2016-07-21 19:20 ` Bandan Das
2016-07-22 8:40 ` Paolo Bonzini
2016-07-22 15:51 ` Bandan Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jpgwpkdd627.fsf@linux.bootlegged.copy \
--to=bsd@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).