From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 500C32820A9 for ; Fri, 20 Mar 2026 02:59:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773975587; cv=none; b=XE2VGN7lSP9Ftx3NZ+SiUNOgQuNIPdeeuytGo4DaZ1BvIEq6zLLOgtj1oQX5smiw536U98egaEr4HYqiO7i+nyCkpiDrivqvImrutUK2PGkNXlzYGOjQLfQIQKhWoLNqiJO6jYXKpEC3eC0im3xrfr/xSmsLZB3+mh6FuNKV0ZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773975587; c=relaxed/simple; bh=IGZT/b2Wb5kjS/Sd+XkL28nXnaB9P5G3WNDz4tdsboc=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=JhMOo28zuX9UCWnoYKm+YdE49TRe83ii5Q7a4c5fjtF1xiC0OV5WO82oeKQfXycnNkAqF5TKl55aa4FXz9j8ZD2pGGozhvaN0Rk7lygDqtyat56tp7h0iD5f4VakpCs4ah9PR5FXJaNVEatSzhjlWgV+blsXRp3RoWBwteLUHuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V6jd6bWs; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V6jd6bWs" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-354a18c48b5so1120747a91.1 for ; Thu, 19 Mar 2026 19:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773975585; x=1774580385; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=UGX89m0PohXrr797EE31OQ2fn8215Se8Vp7bchpg7Ng=; b=V6jd6bWs5C0dPh8RZWl13SCDGqn34DMzeOeyLW95gj8BiUbMCiMpLBZPVQ7qKltfq6 Si4Le3aVNR2UXcq5/z6I/lyFGtlsmVI2Z3bkmgkTqW2rh4eFb58mK5o/9jv4OoOkv+HO y0mlAtjT35K3BiYvx3u+r11PK0Tih+DjzoY2sT6/3OrJKsMjA9BSHHbduOoVYAVKwvAa eSXZi8IN6LKJv2H5K3kugwEhgKmgdttJYTduighpxtE6LAKyLf5j5z3tgEn3a69oaY1i GbiilxmVbc+lTLd6LOzgeXm1y69dY1v1cY3oj5x4DpgFOz3KSbqj6lYLIu29YrAyE5ch cXjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773975585; x=1774580385; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UGX89m0PohXrr797EE31OQ2fn8215Se8Vp7bchpg7Ng=; b=daz5vcl1F5tENWAZ+TYD2jwuxJ+4eisorZoWPrGpKlmTE5vqMH4LYejGYpDHzpSkVl PkjOcgNj0dlFqXDIwD+91emXbv/n/xmEvRripSdE7AZo4LtqjByF4KJ+2eC59F8ZENb4 SAKhSGoixGXipKuZlToJwVhm2ua1NnTH3ulC9lAjNlPSirLpW5BtI32kwu4y5r62m1rM SkSAxp+iuo5340THixTQtMP1limsfhe5QJoCSPbA2EsXAfs/i5Ibq+Xr/C1oaeVFx+7l qv0AR80RXv/0zygERXahKA9T9GUalnmUkmKVC0N81WSm1Fp96eEyxcvtw9VOajYeAbQ+ OzeA== X-Forwarded-Encrypted: i=1; AJvYcCWdVcZlOAe4NVZI1JiCjoTevXpjntKnJqho+GjX70JtyP3zGZ1vF3riH77GAYmhZAiLxtHQIaLNmYwQSFA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6XaPX1p8RjoRnqZog2gor65XcqDh6ot6FD26OJgqIKa/UBsUR Pwn6kpbYI6F8W0PQBOkWXhPTar/agVmUlt3G2PXfaNDdeMayYAWFPx1ihGtWxvdH X-Gm-Gg: ATEYQzw2J+fBWncRbkzdYXWymZxjsZADvYvrPusklIWBgsPWU3p2w/LeMIhHocjGum9 tLDkynyWH1yz/RUbmEKC19a8sXQ7f7lFzkItu+KOltGjqlOX7EUVwuU5+axDsLBAsmFl8iflSuY wEdskL79FvYnWbgSQ/u+NLxtcZlTxn49XUE36Inhy/TCphwBE2auChPKWq6m/r41WF+wfPywr82 +9MqpCMQwfPgrdi3AS7udKVRrmVICn8tfcRVwdkoGIDJ1pdmYlQAT3hUMeCB1iNf2tOVJQWbKbx cd7ooFFC2OfsCR+D/fjsbyx/5aLCyhWQhqUX1zMf6PXjITVjjPnIMneVTBTDzDyBrj5ntzaNCim Rml6GwCj1z6P5/NR58s+TQY9q3M4RbI4PbvenzcyDYimaZGuocsQMkczbSj81gYY5ZoDRpAUG/q K+ShWiblaHDMsVvslGwm6egw== X-Received: by 2002:a17:90b:3b81:b0:359:9073:c368 with SMTP id 98e67ed59e1d1-35bd2d1fe24mr1070777a91.28.1773975584954; Thu, 19 Mar 2026 19:59:44 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bc610c535sm3976321a91.16.2026.03.19.19.59.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 19:59:44 -0700 (PDT) From: Ritesh Harjani (IBM) To: Jiayuan Chen , linux-ext4@vger.kernel.org, jack@suse.cz Cc: Jiayuan Chen , Jiayuan Chen , Theodore Ts'o , Andreas Dilger , Ritesh Harjani , Ye Bin , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] ext4: fix use-after-free in update_super_work when racing with umount In-Reply-To: <20260319120336.157873-1-jiayuan.chen@linux.dev> Date: Fri, 20 Mar 2026 08:23:16 +0530 Message-ID: References: <20260319120336.157873-1-jiayuan.chen@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Jiayuan Chen writes: > From: Jiayuan Chen > > Commit b98535d09179 ("ext4: fix bug_on in start_this_handle during umount > filesystem") moved ext4_unregister_sysfs() before flushing s_sb_upd_work > to prevent new error work from being queued via /proc/fs/ext4/xx/mb_groups > reads during unmount. However, this introduced a use-after-free because > update_super_work calls ext4_notify_error_sysfs() -> sysfs_notify() which > accesses the kobject's kernfs_node after it has been freed by kobject_del() > in ext4_unregister_sysfs(): > > update_super_work ext4_put_super > ----------------- -------------- > ext4_unregister_sysfs(sb) > kobject_del(&sbi->s_kobj) > __kobject_del() > sysfs_remove_dir() > kobj->sd = NULL > sysfs_put(sd) > kernfs_put() // RCU free > ext4_notify_error_sysfs(sbi) > sysfs_notify(&sbi->s_kobj) > kn = kobj->sd // stale pointer > kernfs_get(kn) // UAF on freed kernfs_node > ext4_journal_destroy() > flush_work(&sbi->s_sb_upd_work) Yes, the race between kobject_del() and sysfs_notify() -> kernfs_get() is real. and sysfs_remove_dir() explicitely says: * In general, kobject owner is responsible for ensuring removal * doesn't race with other operations and sysfs doesn't provide any * protection Hence this patch which adds a new mutex lock to prevent the above race, looks good to me. So please feel free to add: Reviewed-by: Ritesh Harjani (IBM)