linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Milton Miller <miltonm@bga.com>
To: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
To: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
Cc: Borislav Petkov <bp@alien8.de>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Rob Landley <rob@landley.net>
Subject: Re: [RFC] netconsole.txt: "nc" needs "-p" to specify the listening port
Subject: [RFC] netconsole.txt: "nc" needs "-p" to specify the listening port
Date: Sun, 29 Jul 2012 03:40:04 -0500	[thread overview]
Message-ID: <kernel-nc-hints@mdm.bga.com> (raw)
In-Reply-To: <gilii4nnxb.fsf@mx10.gouders.net>

[adding Rob as Doc maintanier]

On Sat, 28 Jul 2012 about 11:08:16 -0000, Dirk Gouders wrote:
> Borislav Petkov <bp@alien8.de> writes:
> 
> > On Fri, Jul 27, 2012 at 11:24:53AM +0200, Dirk Gouders wrote:
> >> Cong Wang <xiyou.wangcong@gmail.com> writes:
> >> 
> >> > On Fri, Jul 27, 2012 at 2:35 PM, Dirk Gouders
> >> > <gouders@et.bocholt.fh-gelsenkirchen.de> wrote:
> >> >> Hi Jesse,
> >> >>
> >> >> I would like to ask you to check if the documentation of "nc" in
> >> >> netconsole.txt is still correct.  I tried two different netcat packages
> >> >> and both require "-p" to specify the listening port.  I am wondering if
> >> >> that changed after the use of "nc" has been documented.
> >> >
> >> > On Fedora 16, `nc -u -l <port number>` works fine.
> >> 
> >> Thanks for checking that.
> >> 
> >> If the information I found is correct, Fedora uses OpenBSD's nc
> >> codebase.  The two netcat packages I tested on a Gentoo system differ in
> >> requiring the -p switch for the port specification.
> >
> > So say exactly that in the doc: that the *BSD's version of nc doesn't
> > need the port number specified with '-p' and you're covered.
> OK, I tried that in the attached patch.
> I'm not sure if every exeption needs to/should be documented, though.
> 
> >From 3cdeac3e814471053129145c5fa8391acb365fd8 Mon Sep 17 00:00:00 2001
> From: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
> Date: Sat, 28 Jul 2012 12:32:49 +0200
> Subject: [PATCH] netconsole.txt: non-BSD versions of nc(1) require '-p'
>  switch
> 
> Gentoo for example uses non-BSD versions of nc(1) which require
> the '-p' switch to specify the listening port.
> 
> ---
> Documentation/networking/netconsole.txt |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/networking/netconsole.txt b/Documentation/networking/netconsole.txt
> index 8d02207..9a362f8 100644
> --- a/Documentation/networking/netconsole.txt
> +++ b/Documentation/networking/netconsole.txt
> @@ -52,7 +52,8 @@ initialized and attempts to bring up the supplied dev at the supplied
>  address.
>  
>  The remote host can run either 'netcat -u -l -p <port>',

So the above line shows usage with -p

> -'nc -l -u <port>' or syslogd.
> +'nc -l -u <port>' (BSD version of nc(1) e.g. Fedora),

now you add a comment about BSD and say Fedora which is not obviously
BSD (this is Documentation; reading the git history for clarification
is not approprate).

> +'nc -l -u -p <port>' or syslogd.

And now you add the original -p which you probably skipped over
since it was on the previous line?


>  
>  Dynamic reconfiguration:
>  ========================

milton

  reply	other threads:[~2012-07-29  8:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27  6:35 [RFC PATCH] netconsole.txt: "nc" needs "-p" to specify the listening port Dirk Gouders
2012-07-27  9:02 ` Cong Wang
2012-07-27  9:24   ` Dirk Gouders
2012-07-27 13:15     ` Borislav Petkov
2012-07-28 11:08       ` Dirk Gouders
2012-07-29  8:40         ` Milton Miller [this message]
2012-07-29 11:52           ` [RFC] " Dirk Gouders
2012-08-01 14:06           ` Rob Landley
2012-08-01 15:46             ` Dirk Gouders
2012-08-02 20:39               ` Dirk Gouders
2012-08-02 20:41                 ` Jesse Barnes
2012-08-03  5:30                 ` Cong Wang
2012-08-03  6:33                   ` Dirk Gouders
2012-08-08 15:36                     ` Cong Wang
2012-08-09  6:41                       ` Dirk Gouders
2012-08-16 11:46                 ` Rob Landley
2012-08-02 19:57 ` [RFC PATCH] " Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=kernel-nc-hints@mdm.bga.com \
    --to=miltonm@bga.com \
    --cc=bp@alien8.de \
    --cc=gouders@et.bocholt.fh-gelsenkirchen.de \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob@landley.net \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).