The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: mdshahid03@gmail.com, maddy@linux.ibm.com
Cc: mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org,
	sshegde@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org,
	Mohammad Shahid <mdshahid03@gmail.com>,
	Athira Rajeev <atrajeev@linux.ibm.com>,
	Tanushree Shah <tshah@linux.ibm.com>
Subject: Re: [PATCH] powerpc/perf: vpa-dtl: fix resource leak on allocation failure
Date: Wed, 18 Nov 2026 17:02:01 +0530	[thread overview]
Message-ID: <ld6q74um.ritesh.list@gmail.com> (raw)
In-Reply-To: <20261112134455.6880-1-mdshahid03@gmail.com>


mdshahid03@gmail.com writes:

> From: Mohammad Shahid <mdshahid03@gmail.com>
>
> vpa_dtl_event_init acquires dtl_access_lock when initializing the
> first vpa_dtl PMU event.
>
> If vpa_dtl_mem_alloc() fails,the function returns -ENOMEM without
> releasing the semaphore.
>
> Release the semaphore when buffer allocation fails and no other
> PMU events are active.
>
> Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
> ---
>  arch/powerpc/perf/vpa-dtl.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/perf/vpa-dtl.c b/arch/powerpc/perf/vpa-dtl.c
> index 3e3d65b6c796..20eafeaffa6b 100644
> --- a/arch/powerpc/perf/vpa-dtl.c
> +++ b/arch/powerpc/perf/vpa-dtl.c
> @@ -396,6 +396,8 @@ static int vpa_dtl_event_init(struct perf_event *event)
>  
>  	/* Allocate dtl buffer memory */
>  	if (vpa_dtl_mem_alloc(event->cpu)) {
> +		if (dtl_global_refc == 0)
> +			up_write(&dtl_access_lock);
>  		spin_unlock(&dtl_global_lock);
>  		return -ENOMEM;
>  	}


I looked at this code and I am unable to wrap my head around it. We have
dtl_access_lock and dtl_global_lock. Then we have vpa_dtl, which is a
per-cpu variable anyway.

So I am not sure why we need both locks held while doing
vpa_dtl_mem_alloc(). What exactly are they protecting?  Can we move the
allocation out of the lock and just assign dtl->buf later within the
lock?  In one other place I see dtl->buf = NULL without any lock.  Also,
do we need a spinlock to protect dtl_global_refc? Would an atomic
variable not work here?

The above fix is not wrong per se, based on today's code, but it would
be better if someone who owns this code takes another look and fixes its
design while we are at it.

Another motivation for doing this work now is to bring in clang's
context analysis for arch/powerpc/perf/, which can statically check
that such locking rules are followed, provided there are proper
annotations for every lock and the data it protects.

-ritesh


      parent reply	other threads:[~2026-11-18 11:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 13:44 [PATCH] powerpc/perf: vpa-dtl: fix resource leak on allocation failure mdshahid03
2026-11-18  3:56 ` mdshahid03
2026-11-18 11:32 ` Ritesh Harjani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ld6q74um.ritesh.list@gmail.com \
    --to=ritesh.list@gmail.com \
    --cc=atrajeev@linux.ibm.com \
    --cc=chleroy@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mdshahid03@gmail.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=sshegde@linux.ibm.com \
    --cc=tshah@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox