From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 064DB19D071 for ; Mon, 27 Apr 2026 00:37:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777250233; cv=none; b=U7lL/DvR+LenUEnCcpwVnRGf96OUJrpPk8XKF7wdHk1HcWZJCfBMjuJbv2oHjS2/mwAXj+zq+fXhCkeLS/TdI922jT0e8Xc6Xv3OeDgslsE5Nacsbpk8XbWglUgEMNmJoE8ZNqWq7Che+YL8ItPTXl2CCtHe1WGNR1UqtvBWLmQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777250233; c=relaxed/simple; bh=JA7fhWQUKJ7bKOO5WZ2l4tLYAxtvAQeGMTMWREFP7ac=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=Ysg3dxJB7h4LcRVCJQO+uzyZ32yOnzwiCNCTwB7NXPrKXgIJ4MSt9JR/GQII1DSroGMPGLvfIlhUYXxLAW+ijavd9dJKqosa+7JdafHEULRo1b5UxnooEz7uhwwOVsvN7hFgSBKWN9KOYzRMwwjudRK1LhMUOrPCYeyb48Vijtg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mTyGJ4tI; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mTyGJ4tI" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-82f1f6103afso4384562b3a.1 for ; Sun, 26 Apr 2026 17:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777250231; x=1777855031; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=mVdfUhTIoRGg+RbxdXBCn/qp3+VQxZ3cyedRP11wnO8=; b=mTyGJ4tIEkwcSzOMZM7wAAaDbcvVUrt9wbByfgJ4/esK9zB/pGp0DaNtgGSDMnih60 REwRmeA9M8HeOyta5gOi2YFvTFIYetAAFf3ApdyEF7aATEG1yQikhiKKub7j5hIjSrVi drEzT9sThYH5dZ3dULmetSZVOMtIP8G7M3Fgh1ZvdolS3W6aCJ3h56Ri1ZrLqyKRcyP4 mJcfsdSxtj9c96RPHKIfmUXPH5BAK8ayPuvIoDaS+v5fHZhSzu7IW6dJkpmpTG86Jghk wPuN5ewG2OJuG7KFSj6dauZjwfvSsNtZMaTyE5bfT+himnZlJaNpWY2LsqtRHLEBAPNy kjEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777250231; x=1777855031; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mVdfUhTIoRGg+RbxdXBCn/qp3+VQxZ3cyedRP11wnO8=; b=XcPGLvYucO8Znu1EmrXNdI/+mu/DWxgp13jQ+1m7XXRTgtupMyspEg4lGm3maMPPwn fH3D1SGMdDrGokVPnvsDyhWtRymqXtZgx1kNA7WldO8ypKvvTjqGUJzn0KmcGS3pY+KO ddisvR0W1QqOK7C+akP2vdsAAa7aJ9Kc2Goq0Q5yRxj2rlWJkYYf2E16Fev6oyk69jwh MryrzlYLAbGtaOpVV73vaZWjWfODKaGtbx3fHmEnJghRnAT5ZAAaHIwEj9o48x8Euax1 uvxLh3XVqeSVPZAxysYSIyI7rsAHo/qeDNnOVayjYFLqwV8HhlsX14kp/fbOGQqX8DGm Zm9w== X-Forwarded-Encrypted: i=1; AFNElJ9MDKpmlne1xBuN29dLc9pVLe0a+MtYFLPHr92Lx2p8gBcPdioPJ+bg6qMLEgJhX95TUuJnmdgjf8PWV+o=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7QZj3z6jATTkpctHx+eHrkjvavp4V2HIDmsbg2WzD8PJYhtEb Az3h5TFxaD3iqnRSw5D+0OXClsb3CrFXcKkrimX2T7ZXkeiOP2UCMR4L5TJgMg== X-Gm-Gg: AeBDiesFo8QVpW0BexvI5rCHfwA2PTSBgQaqRvu9pKhYEs81edRP00zISu9Mre60oS4 LCny7r9+TUajB9IWeTi421tkC7u8Dp532wisvCNSGotShld5jJjsCDm2hghwiBqPbEf3gRir07I ASlS9XipLxtATGLmwFFF2axx6plbzOUSrAZQsTcikYhwgY4KQzoTuFtEJilGrdp/O9Lskh5RwAP fYz73MBlBY441EwotAj+zMFZIO2ONrgN4JQS6E5QRI0V8WjeXFzaVfyQuGqQiyKAMB2eIibeTwS 5SJcV5HnixmT49r1xXIg5ZQWkClNBhACEyVKMtL/Utk8+w01yKlHLIbco3e1wl2gA0AFuicmDhD Q7u2FIBybo1WdwrkOO7F66z6vLTE1sV5IyRozIvQYJzjkdBZQHR656c/rYpvxt109QWwJt5jFgQ jX1YnJd+oI9IAqqaoI/C50hMjZtWse2yGL2pvukpyai0E= X-Received: by 2002:a05:6a00:4308:b0:82f:3733:2f96 with SMTP id d2e1a72fcca58-82f8c82e853mr41049342b3a.8.1777250230657; Sun, 26 Apr 2026 17:37:10 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83336687182sm2598534b3a.35.2026.04.26.17.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 17:37:09 -0700 (PDT) From: Ritesh Harjani (IBM) To: Gautam Menghani , maddy@linux.ibm.com, npiggin@gmail.com, mpe@ellerman.id.au, chleroy@kernel.org Cc: Gautam Menghani , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: PPC: Book3S HV: Add H_FAC_UNAVAIL mapping for tracing exits In-Reply-To: <20260424092558.31798-1-Gautam.Menghani@ibm.com> Date: Mon, 27 Apr 2026 06:00:46 +0530 Message-ID: References: <20260424092558.31798-1-Gautam.Menghani@ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Gautam Menghani writes: > From: Gautam Menghani > > The macro kvm_trace_symbol_exit is used for providing the mappings > for the trap vectors and their names. Add mapping for H_FAC_UNAVAIL so that > trap reason is displayed as string instead of a vector number when using > the kvm_guest_exit tracepoint. > > Signed-off-by: Gautam Menghani > --- > arch/powerpc/kvm/trace_book3s.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/trace_book3s.h b/arch/powerpc/kvm/trace_book3s.h > index 9260ddbd557f..eafbaeb5a9db 100644 > --- a/arch/powerpc/kvm/trace_book3s.h > +++ b/arch/powerpc/kvm/trace_book3s.h > @@ -28,6 +28,7 @@ > {0xea0, "H_VIRT"}, \ > {0xf00, "PERFMON"}, \ > {0xf20, "ALTIVEC"}, \ > - {0xf40, "VSX"} > + {0xf40, "VSX"}, \ > + {0xf80, "H_FAC_UNAVAIL"}, So I ended up looking into other trace_symbols too and I don't think we should have a trailing comma here. It may cause some issues silently in trace-cmd or other places. I remember going through it when I was doing some other tracing work earlier but I don't recollect it now. Can we just remove the trailing comma and send a v2 please? btw, 0XF80 is correct as per "arch/powerpc/include/asm/kvm_asm.h" #define BOOK3S_INTERRUPT_H_FAC_UNAVAIL 0xf80 -ritesh