From: Mike Waychison <mike@waychison.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Keys: Pass session keyring to call_usermodehelper()
Date: Wed, 23 Mar 2005 22:25:02 +0000 (UTC) [thread overview]
Message-ID: <loom.20050323T232144-412@post.gmane.org> (raw)
In-Reply-To: 20050323130628.3a230dec.akpm@osdl.org
Andrew Morton <akpm <at> osdl.org> writes:
>
> David Howells <dhowells <at> redhat.com> wrote:
> >
> > The attached patch makes it possible to pass a session keyring through to the
> > process spawned by call_usermodehelper().
>
> hm. Seems likely to attract angry emails due to breakage of out-of-tree
> stuff. Did you consider
>
> static inline int
> call_usermodehelper(char *path, char **argv, char **envp, int wait)
> {
> return call_usermodehelper_keys(path, argv, envp, NULL, wait);
> }
>
An alternative is to have the execve happen in a callback, similar to the
following patch I posted a couple months ago:
http://marc.theaimsgroup.com/?l=linux-kernel&m=109871749900732&w=2
IMHO, this is a better interface as it allows module writers to make arbitrary
changes.
(Some interface for allowing modules to 'safely' do execve is still required
though).
Mike Waychison
next prev parent reply other threads:[~2005-03-23 22:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 20:14 [PATCH 1/3] Keys: Pass session keyring to call_usermodehelper() David Howells
2005-03-23 20:19 ` [PATCH 2/3] Keys: Use RCU to manage session keyring pointer David Howells
2005-03-23 21:07 ` Andrew Morton
2005-03-23 21:28 ` David Howells
2005-03-23 20:52 ` [PATCH 3/3] Keys: Make request-key create an authorisation key David Howells
2005-03-24 11:41 ` [PATCH 3/3] Keys: Make request-key create an authorisation key [try #2] David Howells
2005-03-31 19:50 ` [PATCH 3/3] Keys: Make request-key create an authorisation key Benoit Boissinot
2005-04-01 15:30 ` [PATCH] Keys: Fix request_key default keyring handling David Howells
2005-03-23 20:55 ` [PATCH 2/3] Keys: Use RCU to manage session keyring pointer David Howells
2005-04-11 22:45 ` Paul E. McKenney
2005-04-12 9:11 ` David Howells
2005-04-12 14:50 ` Paul E. McKenney
2005-03-23 21:06 ` [PATCH 1/3] Keys: Pass session keyring to call_usermodehelper() Andrew Morton
2005-03-23 21:26 ` David Howells
2005-03-23 22:34 ` Andrew Morton
2005-03-23 22:49 ` David Howells
2005-03-24 0:58 ` Kyle Moffett
2005-03-23 22:25 ` Mike Waychison [this message]
2005-03-24 11:38 ` [PATCH 1/3] Keys: Pass session keyring to call_usermodehelper() [try #2] David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20050323T232144-412@post.gmane.org \
--to=mike@waychison.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox