From: DM <dm.n9107@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: avoid large irq-latencies in smp-balancing
Date: Fri, 9 Nov 2007 12:41:28 +0000 (UTC) [thread overview]
Message-ID: <loom.20071109T123749-481@post.gmane.org> (raw)
In-Reply-To: 1194437820.6289.114.camel@twins
Peter Zijlstra <peterz <at> infradead.org> writes:
> @@ -2237,7 +2243,7 @@ balance_tasks(struct rq *this_rq, int th
> enum cpu_idle_type idle, int *all_pinned,
> int *this_best_prio, struct rq_iterator *iterator)
> {
> - int pulled = 0, pinned = 0, skip_for_load;
> + int loops = 0, pulled = 0, pinned = 0, skip_for_load;
> struct task_struct *p;
> long rem_load_move = max_load_move;
>
> @@ -2251,10 +2257,10 @@ balance_tasks(struct rq *this_rq, int th
> */
> p = iterator->start(iterator->arg);
> next:
> - if (!p)
> + if (!p || loops++ > sysctl_sched_nr_migrate)
> goto out;
Looks to me like an off-by-one thingy. If sysctl_sched_nr_migrate is zero we
can still migrate one task. Feature or bug?
/dm
prev parent reply other threads:[~2007-11-09 12:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 11:29 [PATCH] sched: avoid large irq-latencies in smp-balancing Peter Zijlstra
2007-11-07 12:17 ` Peter Zijlstra
2007-11-07 18:27 ` Andrew Morton
2007-11-07 18:58 ` Peter Zijlstra
2007-11-07 22:10 ` Steven Rostedt
2007-11-08 0:24 ` Eric St-Laurent
2007-11-08 4:37 ` Gregory Haskins
2007-11-09 13:09 ` Nick Piggin
2007-11-09 12:41 ` DM [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20071109T123749-481@post.gmane.org \
--to=dm.n9107@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox