From: Andrew Jones <drjones@redhat.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/17][RFC] ktest updates for v3.2
Date: Thu, 20 Oct 2011 14:31:17 +0000 (UTC) [thread overview]
Message-ID: <loom.20111020T160741-298@post.gmane.org> (raw)
In-Reply-To: 20111017160455.498567257@goodmis.org
Steven Rostedt <rostedt <at> goodmis.org> writes:
>
> As it is getting close to the merge window. I want to post the
> patches I will be pushing to Linus. I know most people don't even
> use this, but I figured I would show what's changed since the last
> release.
>
> This is also the code base I will be using for my tutorial at
> LinuxCon EU.
>
Hmm, I have a couple comments.
First, all the new additions such as IF, ELSE, DEFINED, INCLUDE are starting to
reinvent 'make' inside of ktest.pl. At the point those constructs were needed,
I'd probably have gone the opposite way. I would have ripped any special parsing
out of ktest.pl, reducing it to only read simple key=value pairs. Then I would
have renamed sample.conf to Makefile and tweaked it for the syntax. Makefile
would then include Makefile.ktest, which would be where users can go to town
with their own custom "configs" using all the make constructs. It would also
have a couple targets, ktest.conf and ktest. ktest.conf would output the
generated, simple key=value config. ktest would run ktest.pl with the generated
config passed to it, either through a file or by using environment variables.
My other comment is that it appears a few of the patches from my August
series[*] got dropped. Please keep in mind that without the CONSOLE_RESET_TIME
patch in that series ktest doesn't work with virtual machine consoles, so
afaict, it's a must have. Also the RERUN patch was necessary for me to use ktest
on my last bisect, since the problem was during boot. Indeed, all the patches in
that series were useful at some point, so I'd appreciate if they were all
integrated.
Drew
[*] http://thread.gmane.org/gmane.linux.kernel/1178676
prev parent reply other threads:[~2011-10-20 14:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 16:04 [PATCH 00/17][RFC] ktest updates for v3.2 Steven Rostedt
2011-10-17 16:04 ` [PATCH 01/17][RFC] ktest: Add TEST_TYPE install option Steven Rostedt
2011-10-17 16:04 ` [PATCH 02/17][RFC] ktest: Create outputdir if it does not exist Steven Rostedt
2011-10-17 16:04 ` [PATCH 03/17][RFC] ktest: Only need to save .config when doing mrproper Steven Rostedt
2011-10-17 16:04 ` [PATCH 04/17][RFC] ktest: Include monitor in reboot code Steven Rostedt
2011-10-17 16:05 ` [PATCH 05/17][RFC] ktest: Fail when grub menu not found Steven Rostedt
2011-10-17 16:05 ` [PATCH 06/17][RFC] ktest: Add NO_INSTALL option to not install for a test Steven Rostedt
2011-10-17 16:05 ` [PATCH 07/17][RFC] ktest: Add option REBOOT_SUCCESS_LINE to stop waiting after a reboot Steven Rostedt
2011-10-17 16:05 ` [PATCH 08/17][RFC] ktest: Do not reboot on config or build issues Steven Rostedt
2011-10-17 16:05 ` [PATCH 09/17][RFC] ktest: Add IF and ELSE to config sections Steven Rostedt
2011-10-17 16:05 ` [PATCH 10/17][RFC] ktest: Let IF keyword take comparisons Steven Rostedt
2011-10-17 16:05 ` [PATCH 11/17][RFC] ktest: Add INCLUDE keyword to include other config files Steven Rostedt
2011-10-17 16:05 ` [PATCH 12/17][RFC] ktest: Consolidate TEST_TYPE and DEFAULT code Steven Rostedt
2011-10-17 16:05 ` [PATCH 13/17][RFC] ktest: Add OVERRIDE keyword to DEFAULTS section Steven Rostedt
2011-10-17 16:05 ` [PATCH 14/17][RFC] ktest: Add DEFINED keyword for IF statements Steven Rostedt
2011-10-17 16:05 ` [PATCH 15/17][RFC] ktest: Sort make_min_config configs by dependecies Steven Rostedt
2011-10-17 16:05 ` [PATCH 16/17][RFC] ktest: Fix parsing of config section lines Steven Rostedt
2011-10-17 16:05 ` [PATCH 17/17][RFC] ktest: Add processing of complex conditionals Steven Rostedt
2011-10-20 14:31 ` Andrew Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20111020T160741-298@post.gmane.org \
--to=drjones@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox