From: JohnG <jhnlmn@yahoo.com>
To: linux-kernel@vger.kernel.org
Subject: Re: fanotify issues in 2.6.34-rc6-next-20100506
Date: Mon, 4 Jun 2012 01:49:17 +0000 (UTC) [thread overview]
Message-ID: <loom.20120604T034814-206@post.gmane.org> (raw)
In-Reply-To: 1273251421.15368.208.camel@localhost
> On Fri, 2010-05-07 at 11:24 +0200, Anders Blomdell wrote:
> ... switch statements are hard.
Two years passed, but this patch was never applied
and fanotify is as broken as it has been.
So, two questions:
- does anyone going to finally apply that patch (add "break" before case
(FSNOTIFY_EVENT_NONE) in should_merge)
- what is the status of fanotify? Does anybody still use it? Does it work (aside
from this bug?)
Just in case, I copied that old patch below:
diff --git a/fs/notify/fanotify/fanotify.c b/fs/notify/fanotify/fanotify.c
index bbcfccd..34c9661 100644
a/fs/notify/fanotify/fanotify.c
+++ b/fs/notify/fanotify/fanotify.c
@@ -21,6 +21,7 @@ static bool should_merge(struct fsnotify_event *old, struct
fsnotify_event *new)
if ((old->path.mnt == new->path.mnt) &&
(old->path.dentry == new->path.dentry))
return true;
+ break;
case (FSNOTIFY_EVENT_NONE):
return true;
default:
prev parent reply other threads:[~2012-06-04 1:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 9:24 fanotify issues in 2.6.34-rc6-next-20100506 Anders Blomdell
2010-05-07 13:21 ` Eric Paris
2010-05-07 16:57 ` Eric Paris
2012-06-04 1:49 ` JohnG [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20120604T034814-206@post.gmane.org \
--to=jhnlmn@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox