Re: [PATCH 3.16 289/305] netfilter: x_tables: validate targets of jumps

Ben Hutchings
2016-11-12T02:29:51Z

[-- Attachment #1: Type: text/plain, Size: 821 bytes --]

On Sat, 2016-08-13 at 20:30 +0200, Florian Westphal wrote:
> Ben Hutchings <ben@decadent.org.uk> wrote:
> > 3.16.37-rc1 review patch.  If anyone has any objections, please let
> > me know.
> >
> > ------------------
> >
> > From: Florian Westphal <fw@strlen.de>
> >
> > commit 36472341017529e2b12573093cc0f68719300997 upstream.
>
> [..]
>
> > The extra overhead is negible, even with absurd cases.
>
> Not true, the overhead is huge and increases restore time for
> large rulesets from mere seconds to minutes, see
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commi
> t/?id=f4dc77713f8016d2e8a3295e1c9c53a21f296def

I've queued both of these up for the next update.

Ben.

--
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]