Re: [PATCH 3.16 302/370] drm/radeon: Use mode h/vdisplay fields to hide out of bounds HW cursor

Ben Hutchings
2017-03-14T16:50:43Z

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

On Mon, 2017-03-13 at 12:35 +0900, Michel Dänzer wrote:
> On 10/03/17 08:46 PM, Ben Hutchings wrote:
> > 3.16.42-rc1 review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > > > From: Michel Dänzer <michel.daenzer@amd.com>
> >
> > commit d74c67dd7800fc7aae381f272875c337f268806c upstream.
> >
> > The crtc_h/vdisplay fields may not match the CRTC viewport dimensions
> > with special modes such as interlaced ones.
> >
> > Fixes the HW cursor disappearing in the bottom half of the screen with
> > interlaced modes.
> >
> > Fixes: 6b16cf7785a4 ("drm/radeon: Hide the HW cursor while it's out of bounds")
>
> It might make sense to squash together the backports of this commit and
> 6b16cf7785a4, or at least move them closer together in the series, to
> prevent people from hitting the regressed state.

I hardly ever squash commits together, as it's easier to keep track of
what has been applied if there is a one-to-one mapping.

I will move these two together in the series, but there are lots of
other cases like this on stable branches.

Ben.

--
Ben Hutchings
The obvious mathematical breakthrough [to break modern encryption]
would be
development of an easy way to factor large prime numbers. - Bill Gates

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]