Re: [PATCH 3.16 10/72] video: of: display_timing: Add of_node_put() in of_get_display_timing()

Thierry Reding
2019-12-10T13:27:38Z

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

On Mon, Dec 09, 2019 at 01:19:01PM -0800, Doug Anderson wrote:
> Hi,
>
> On Sun, Dec 8, 2019 at 5:54 AM Ben Hutchings <ben@decadent.org.uk> wrote:
> >
> > 3.16.79-rc1 review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Douglas Anderson <dianders@chromium.org>
> >
> > commit 4faba50edbcc1df467f8f308893edc3fdd95536e upstream.
> >
> > =46romcode inspection it can be seen that of_get_display_timing() is
> > lacking an of_node_put(). Add it.
>
> I don't object, but I am curious why "From code" got turned into
> "=46romcode" in the commit message.

I vaguely recall earlier versions of patchwork doing something similar.
This has to do with lines starting with "From" needing special treatment
in some situations. I'm not exactly sure about the details, but I think
this is only needed for the mailbox format, so whatever happened here
was probably a bit over the top.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]