Re: [PATCH 3.16 10/72] video: of: display_timing: Add of_node_put() in of_get_display_timing()

Ben Hutchings
2019-12-10T15:52:48Z

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

On Tue, 2019-12-10 at 14:27 +0100, Thierry Reding wrote:
> On Mon, Dec 09, 2019 at 01:19:01PM -0800, Doug Anderson wrote:
> > Hi,
> >
> > On Sun, Dec 8, 2019 at 5:54 AM Ben Hutchings <ben@decadent.org.uk> wrote:
> > > 3.16.79-rc1 review patch. If anyone has any objections, please let me know.
> > >
> > > ------------------
> > >
> > > From: Douglas Anderson <dianders@chromium.org>
> > >
> > > commit 4faba50edbcc1df467f8f308893edc3fdd95536e upstream.
> > >
> > > =46romcode inspection it can be seen that of_get_display_timing() is
> > > lacking an of_node_put(). Add it.
> >
> > I don't object, but I am curious why "From code" got turned into
> > "=46romcode" in the commit message.
>
> I vaguely recall earlier versions of patchwork doing something similar.
> This has to do with lines starting with "From" needing special treatment
> in some situations. I'm not exactly sure about the details, but I think
> this is only needed for the mailbox format, so whatever happened here
> was probably a bit over the top.

I generate a single mbox file for review, and then feed that through
"formail ... sendmail". So "From " in a mail body does need to be
escaped (but this shouldn't be visibile to receivers). The Perl MIME
module doesn't handle mbox output, so I had to implement it myself and
I got this wrong. I've now committed a fix so this shouldn't happen
again.

Ben.

--
Ben Hutchings
Experience is directly proportional to the value of equipment destroyed
- Carolyn Scheppner

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]