From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E55112BF24 for ; Tue, 19 Nov 2024 01:58:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731981499; cv=none; b=Os4JWsX/XZxf3lVHhYl7whR54AiYrKGAWXamQHNvk8NIlQHl65962slpYyhGBU/rcpMJyzbm09foS3j6baPBRN7Po3JLbxJmy5mdstcWrgo+bsAE54zJMF7JFI5O3YWwrRpZYEXFT3IbCEDMsnFekBK1RKeOvyb2XSjsBc852ok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731981499; c=relaxed/simple; bh=ib43JGOIZ1ATJp9/a9ElmBK4S1TyxSpfZHQfvMpHa/s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jrBpZjRDQiQBV6tl3AumoG9FVFQG3d410iyYn1fg4T3JYRTN/iuCF3hSNwyc09raATLMqxTbltSYoNguDNg9rivcjZgzxTkinxeUAVkaaHbbDdofcCfusBw57f1PSARhAKEEK4ROE16yXJHbLWi+pUvzUIwKkt0Hn0wLlL3+9OY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sb7duX0n; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sb7duX0n" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2fb4fa17044so23937601fa.3 for ; Mon, 18 Nov 2024 17:58:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731981496; x=1732586296; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wdC7Ydz7m1dNRr4+gLJERncdScN7zJGfk7xMkgiJr2o=; b=sb7duX0nQharmQd8lGWsRWNFceN8fSeiJSAUt9HnEZxw36K+HS71/8J/Suw54AfoXz M0SvTAkT6nv3x5RmiVVgPfTmjbyyP3JsA3kTC9sQ2oWocyEh3RYicuBjwa4Fk9N/vY2p g/GPzZmk7t9NAWSHbuo4Y2rpLBkrt2fMDFn6EDN6vuOd4Y/UzauIdhv7zx8hT4YTldka rc7wJxgOwc0LTV5aNvgUK/K/epsRe+NLHvEcbmYT/ZoZdTH0jayV5/cgWtWZnZgfIQxr nadD1C/FYkCBDmC1oUxwofooLflMBeoT6PolNYsi4+UhPGaQ1P1w7/8JD1M9cXTfd4lM SdPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731981496; x=1732586296; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wdC7Ydz7m1dNRr4+gLJERncdScN7zJGfk7xMkgiJr2o=; b=MO0QqnYjgmEWLWl8Be7V/yERJUKBKgUok7pVn0dchzYDthjlfW1erpfmXFDwBIHR+Q vSI+u/EWi5DQFGFt7uB/3Fyw3Cfc4k6xWVK6/vGxno/dL8Ju45q+E3CaeuAbT0VpjD3c uI/dhLURr93hypuNmX0LF60/QMBTbfmxscQpLYVT1FocuDwYErKVIA97pQ3hu+hcmHCX ECHSh+ux5Oc5RdEq/WlZio6ZNbljurqQ53zOBu1l0oceCNuBLi5QHRPUz5CJOGeIMYuI KO1d9M8YjobVQl/fV9OuKiPKK877Kuj1bb+ZgjuVhxvbwl6vg+4eYPUYvIJsRA3LZGfm 5OKQ== X-Forwarded-Encrypted: i=1; AJvYcCVQwdvW8raJt8hI1FY7Ct7Edb+lwTT/iPowqRzmzB+fCVJv9aVadKTWUuYFYiXR9wDI5LGZVmGkoMi5AdU=@vger.kernel.org X-Gm-Message-State: AOJu0YyVvQbIHlUnKldEol9UpsDrkx1VGMaSb3FAUahWAPwtLIsRjbkz jaXCYPWRzggcW+fAMOL23tRzu9IrkWO16E9bYGyXpKDdcy4nXawzi3pPbWUD4HA= X-Google-Smtp-Source: AGHT+IFh0Cuv9/HfcvnF4zuwr0S46WRrJc62S0qKB/X9mLPdDDoNco2zDj4DDugU5E//exJwUKsY7g== X-Received: by 2002:a2e:bd02:0:b0:2ff:5630:b9a4 with SMTP id 38308e7fff4ca-2ff60711fe3mr60427691fa.38.1731981495555; Mon, 18 Nov 2024 17:58:15 -0800 (PST) Received: from eriador.lumag.spb.ru (2001-14ba-a0c3-3a00--7a1.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::7a1]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ff69851184sm10527051fa.15.2024.11.18.17.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2024 17:58:14 -0800 (PST) Date: Tue, 19 Nov 2024 03:58:10 +0200 From: Dmitry Baryshkov To: Melody Olvera Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Trilok Soni , Satya Durga Srinivasu Prabhala , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue Subject: Re: [PATCH v2 2/7] clk: qcom: rpmh: Add support for SM8750 rpmh clocks Message-ID: References: <20241112002807.2804021-1-quic_molvera@quicinc.com> <20241112002807.2804021-3-quic_molvera@quicinc.com> <5pgwerxhqhyr2u47grqzgzvvng4rojzq4gozil7vy37bew5pqj@wt676vfjs7bg> <8d3c2efd-b6c3-4b01-ae01-78460f4e9f26@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d3c2efd-b6c3-4b01-ae01-78460f4e9f26@quicinc.com> On Mon, Nov 18, 2024 at 10:53:16AM -0800, Melody Olvera wrote: > On 11/15/2024 7:31 AM, Dmitry Baryshkov wrote: > > On Mon, Nov 11, 2024 at 04:28:02PM -0800, Melody Olvera wrote: > > > From: Taniya Das [...] > > > @@ -894,6 +919,7 @@ static const struct of_device_id clk_rpmh_match_table[] = { > > > { .compatible = "qcom,sa8775p-rpmh-clk", .data = &clk_rpmh_sa8775p}, > > > { .compatible = "qcom,sar2130p-rpmh-clk", .data = &clk_rpmh_sar2130p}, > > > { .compatible = "qcom,sc7180-rpmh-clk", .data = &clk_rpmh_sc7180}, > > > + { .compatible = "qcom,sc7280-rpmh-clk", .data = &clk_rpmh_sc7280}, > > > { .compatible = "qcom,sc8180x-rpmh-clk", .data = &clk_rpmh_sc8180x}, > > > { .compatible = "qcom,sc8280xp-rpmh-clk", .data = &clk_rpmh_sc8280xp}, > > > { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845}, > > > @@ -909,7 +935,7 @@ static const struct of_device_id clk_rpmh_match_table[] = { > > > { .compatible = "qcom,sm8450-rpmh-clk", .data = &clk_rpmh_sm8450}, > > > { .compatible = "qcom,sm8550-rpmh-clk", .data = &clk_rpmh_sm8550}, > > > { .compatible = "qcom,sm8650-rpmh-clk", .data = &clk_rpmh_sm8650}, > > > - { .compatible = "qcom,sc7280-rpmh-clk", .data = &clk_rpmh_sc7280}, > > Please don't mix fixes and actual code. I'd suggest splitting sc7280 > > move to the separate commit. > > Bryan O'Donoghue requested we sort these as part of this patch. I don't feel > strongly either way, > but clear guidance here would be appreciated. I don't see v1 of this patch on the linux-arm-msm list (hint: use b4 tool to send patches), so I can not comment on what Bryan ment. But I'd definitely say, moving of the sc7280 entry is a _separate_ commit. > > Thanks, > Melody > > > > > > + { .compatible = "qcom,sm8750-rpmh-clk", .data = &clk_rpmh_sm8750}, > > > { .compatible = "qcom,x1e80100-rpmh-clk", .data = &clk_rpmh_x1e80100}, > > > { } > > > }; > > > -- > > > 2.46.1 > > > > -- With best wishes Dmitry