From: ebiederm@xmission.com (Eric W. Biederman)
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
containers@lists.osdl.org,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
"Serge E. Hallyn" <serue@us.ibm.com>,
Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 3/3] ftrace: add ability to only trace swapper tasks
Date: Thu, 04 Dec 2008 12:41:08 -0800 [thread overview]
Message-ID: <m11vwnu10b.fsf@frodo.ebiederm.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0812040946060.5240@gandalf.stny.rr.com> (Steven Rostedt's message of "Thu, 4 Dec 2008 09:46:28 -0500 (EST)")
Steven Rostedt <rostedt@goodmis.org> writes:
> On Thu, 4 Dec 2008, Eric W. Biederman wrote:
>
>> Ingo Molnar <mingo@elte.hu> writes:
>>
>> > * Andrew Morton <akpm@linux-foundation.org> wrote:
>> >
>> >> > Signed-off-by: Steven Rostedt <srostedt@redhat.com>
>> >>
>> >> What does this patch actually do? Is swapper currently excluded from
>> >> tracing for undisclosed reasons and this patch permits it to be traced?
>> >> If so, why was swapper thus excluded? Or am I totally off track?
>> >
>> >> > +static struct pid * const ftrace_swapper_pid = (struct pid *)1;
>> >>
>> >> eh?
>> >
>> > all side-effects of getting rid of the integer based PID namespace and
>> > replacing them with struct pid pointers.
>>
>> Thanks for asking Andrew it looks like an unnecessary side effect.
>
> Well, it was necessary without hacking fork.c ;-)
The (struct pid *)1 has always been unnecessary.
As for fork. It would be nice to remove most of the special cases
for the idle thread. At least the counts are significant. The rest
is pretty much a don't care at this point.
Eric
next prev parent reply other threads:[~2008-12-04 20:46 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 5:26 [PATCH 0/3] ftrace: clean ups for tip Steven Rostedt
2008-12-04 5:26 ` [PATCH 1/3] fix the do_each_pid_task macro Steven Rostedt
2008-12-04 5:26 ` [PATCH 2/3] ftrace: use struct pid Steven Rostedt
2008-12-04 12:42 ` Eric W. Biederman
2008-12-04 12:56 ` Dave Hansen
2008-12-04 13:07 ` Dave Hansen
2008-12-04 13:40 ` Eric W. Biederman
2008-12-04 15:12 ` Dave Hansen
2008-12-04 15:35 ` Steven Rostedt
2008-12-04 15:41 ` Dave Hansen
2008-12-04 15:44 ` Steven Rostedt
2008-12-04 14:29 ` Steven Rostedt
2008-12-05 3:17 ` Dipankar Sarma
2008-12-04 12:55 ` Eric W. Biederman
2008-12-04 14:23 ` Steven Rostedt
2008-12-04 14:32 ` Eric W. Biederman
2008-12-04 16:22 ` Sukadev Bhattiprolu
2008-12-04 5:26 ` [PATCH 3/3] ftrace: add ability to only trace swapper tasks Steven Rostedt
2008-12-04 5:34 ` Wang Liming
2008-12-04 5:50 ` Wang Liming
2008-12-04 8:06 ` Ingo Molnar
2008-12-04 8:18 ` Andrew Morton
2008-12-04 9:10 ` Ingo Molnar
2008-12-04 12:59 ` Eric W. Biederman
2008-12-04 14:46 ` Steven Rostedt
2008-12-04 20:41 ` Eric W. Biederman [this message]
2008-12-04 20:57 ` Steven Rostedt
2008-12-04 21:43 ` Eric W. Biederman
2008-12-04 21:56 ` Steven Rostedt
2008-12-05 7:43 ` Eric W. Biederman
2008-12-05 12:23 ` Steven Rostedt
2008-12-05 16:35 ` Eric W. Biederman
2008-12-05 4:30 ` [PATCH] ftrace: use init_struct_pid as swapper pid Steven Rostedt
2008-12-05 13:51 ` Ingo Molnar
2008-12-04 15:36 ` [PATCH 3/3] ftrace: add ability to only trace swapper tasks Ingo Molnar
2008-12-04 15:47 ` Steven Rostedt
2008-12-04 13:12 ` Steven Rostedt
2008-12-04 13:52 ` Eric W. Biederman
2008-12-04 12:54 ` Eric W. Biederman
2008-12-04 14:57 ` Steven Rostedt
2008-12-04 8:10 ` [PATCH 0/3] ftrace: clean ups for tip Ingo Molnar
2008-12-04 8:30 ` [PATCH] tracing: fix typo Ingo Molnar
2008-12-04 8:34 ` [PATCH] tracing: fix typo and missing inline function Ingo Molnar
2008-12-04 13:16 ` Steven Rostedt
2008-12-04 15:35 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m11vwnu10b.fsf@frodo.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=dave@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=serue@us.ibm.com \
--cc=srostedt@redhat.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox