From: ebiederm@xmission.com (Eric W. Biederman)
To: Roland Dreier <rdreier@cisco.com>
Cc: Roland Dreier <roland@digitalvampire.org>,
Greg KH <greg@kroah.com>,
linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg()
Date: Wed, 03 Oct 2007 14:34:58 -0600 [thread overview]
Message-ID: <m11wccc4y5.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <adaejgcdkyn.fsf@cisco.com> (Roland Dreier's message of "Wed, 03 Oct 2007 13:03:44 -0700")
Roland Dreier <rdreier@cisco.com> writes:
> > Well it is a bug worth fixing. Who knows it may have something
> > to do with the disable_irq problems the forcedeth driver was seeing.
>
> I agree completely, the fix looks obvious and there's no point in
> leaving the bug there. I just don't have a test case that I can point
> to as being fixed by this, since I don't have a working 32-bit MSI
> device...
>
> Do you know whether the forcedeth devices have a 32-bit MSI address?
Sorry I don't. The ones I have don't have an MSI capability.
Eric
prev parent reply other threads:[~2007-10-03 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87abr0oyj4.fsf@shaolin.home.digitalvampire.org>
2007-10-03 18:25 ` MSI: Use correct data offset for 32-bit MSI in read_msi_msg() Eric W. Biederman
2007-10-03 19:13 ` Roland Dreier
2007-10-03 19:55 ` Eric W. Biederman
2007-10-03 20:03 ` Roland Dreier
2007-10-03 20:34 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m11wccc4y5.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=rdreier@cisco.com \
--cc=roland@digitalvampire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox