From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>,
linux-kernel@vger.kernel.org, devel@openvz.org, adobriyan@sw.ru,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.
Date: Thu, 09 Aug 2007 20:12:14 -0600 [thread overview]
Message-ID: <m11wec87ep.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070809185521.c3ab1afd.akpm@linux-foundation.org> (Andrew Morton's message of "Thu, 9 Aug 2007 18:55:21 -0700")
Andrew Morton <akpm@linux-foundation.org> writes:
> But it is good to remove bad interfaces, if we possibly can.
>
> It is worth making the attempt. Does anyone know of anything which will
> break? I fed NET_NEIGH_ANYCAST_DELAY at random into
> http://www.google.com/codesearch and came up with nothing...
My current policy is that since I could only find 5 real world linux
programs that even call sys_sysctl, that if I find a broken sysctl
binary interface I'm lazy and just remove it. The only networking one
I know of is radvd.
Added to that I just pushed an autochecking sysctl patch to Andrew
that fails register_sysctl_table if the sysctl table is broken. And
all of these showed up. So some fix was needed or things would have
been even worse.
Eric
next prev parent reply other threads:[~2007-08-10 2:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 16:45 [PATCH] Remove CTL_UNNUMBERED Alexey Dobriyan
2007-07-26 17:24 ` Eric W. Biederman
2007-07-27 14:52 ` Alexey Dobriyan
2007-08-06 12:45 ` [PATCH 2/2] sysctl: remove CTL_UNNUMBERED Alexey Dobriyan
2007-08-09 19:44 ` Eric W. Biederman
2007-08-09 19:50 ` [PATCH 1/3] sysctl core: Stop using the unnecessary ctl_table typedef Eric W. Biederman
2007-08-09 19:52 ` [PATCH 2/3] sysctl: Factor out sysctl_data Eric W. Biederman
2007-08-09 20:09 ` [PATCH 3/3] sysctl: Error on bad sysctl tables Eric W. Biederman
2007-08-10 0:49 ` [PATCH 01/10] sysctl: Update sysctl_check_table Eric W. Biederman
2007-08-10 0:51 ` [PATCH 02/10] sysct mqueue: Remove the binary sysctl numbers Eric W. Biederman
2007-08-10 0:53 ` [PATCH 03/10] sysctl: Remove binary sysctl support where it clearly doesn't work Eric W. Biederman
2007-08-10 0:56 ` [PATCH 04/10] sysctl: Fix neighbour table sysctls Eric W. Biederman
2007-08-10 0:57 ` [PATCH 05/10] sysctl: ipv6 route flushing (kill binary path) Eric W. Biederman
2007-08-10 0:58 ` [PATCH 06/10] sysctl: Remove broken sunrpc debug binary sysctls Eric W. Biederman
2007-08-10 0:59 ` [PATCH 07/10] sysctl: x86_64 remove unnecessary binary paths Eric W. Biederman
2007-08-10 1:01 ` [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls Eric W. Biederman
2007-08-10 1:02 ` [PATCH 09/10] sysctl: ipv4 remove binary sysctl paths where they are broken Eric W. Biederman
2007-08-10 1:03 ` [PATCH 10/10] sysctl: Remove the binary interface for aio-nr, aio-max-nr, acpi_video_flags Eric W. Biederman
2007-08-10 13:33 ` [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls Alan Cox
2007-08-10 15:55 ` Eric W. Biederman
2007-08-10 17:16 ` Alan Cox
2007-08-10 18:30 ` Eric W. Biederman
2007-08-10 1:04 ` [PATCH 06/10] sysctl: Remove broken sunrpc debug " Eric W. Biederman
2007-08-10 1:47 ` [PATCH 04/10] sysctl: Fix neighbour table sysctls YOSHIFUJI Hideaki / 吉藤英明
2007-08-10 1:49 ` David Miller
2007-08-10 2:14 ` YOSHIFUJI Hideaki / 吉藤英明
2007-08-10 2:23 ` Eric W. Biederman
2007-08-10 2:29 ` YOSHIFUJI Hideaki / 吉藤英明
2007-08-10 2:35 ` Eric W. Biederman
2007-08-10 1:55 ` Andrew Morton
2007-08-10 2:12 ` Eric W. Biederman [this message]
2007-08-10 2:22 ` YOSHIFUJI Hideaki / 吉藤英明
2007-08-10 2:01 ` [PATCH 3/3] sysctl: Error on bad sysctl tables YOSHIFUJI Hideaki / 吉藤英明
2007-08-10 2:15 ` Eric W. Biederman
2007-08-10 2:18 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m11wec87ep.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=adobriyan@sw.ru \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox