public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Sam Vilain <sam@vilain.net>
Cc: linux-kernel@vger.kernel.org, dev@sw.ru, herbert@13thfloor.at,
	devel@openvz.org, ebiederm@xmission.com, xemul@sw.ru,
	Dave Hansen <haveblue@us.ibm.com>, Andrew Morton <akpm@osdl.org>,
	Cedric Le Goater <clg@fr.ibm.com>,
	serue@us.ibm.com
Subject: Re: [PATCH] namespaces: uts_ns: make information visible via /proc/PID/uts directory
Date: Mon, 22 May 2006 10:39:08 -0600	[thread overview]
Message-ID: <m11wumm2tv.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060522052425.27715.94562.stgit@localhost.localdomain> (Sam Vilain's message of "Mon, 22 May 2006 17:24:25 +1200")

Sam Vilain <sam@vilain.net> writes:

> From: Sam Vilain <sam.vilain@catalyst.net.nz>
>
> Export the UTS information to a per-process directory /proc/PID/uts,
> that has individual nodes for hostname, ostype, etc - similar to
> those in /proc/sys/kernel
>
> This duplicates the approach used for /proc/PID/attr, which involves a
> lot of duplication of similar functions.  Much room for maintenance
> optimisation of both implementations remains.
> ---
> Sorry for the duplication of this to the list, stuffed up the stgit
> command.
>
> After doing this I noticed that the whole way this is done via sysctls
> in /proc/sys is much, much nicer.  I was going there to make
> /proc/sys/kernel/osname -> /proc/self/uts/sysname (etc), but it seems
> that symlinks from /proc/sys are not a done thing.
>
> Is there an argument here perhaps for some integration between the way
> this is done for /proc/sys and /proc/PID/xxx ?
>
>  fs/proc/base.c |  236 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 236 insertions(+), 0 deletions(-)

Good intentions :)
But since this doesn't actually fix /proc/sys/kernel/osname and friends.
I would call this implementation a failure.

Let's first fix /proc/sys/kernel/osname to be sensitive to the caller,
and then see if we can make /proc/sys a symlink to /proc/<pid>/sys


Eric

  parent reply	other threads:[~2006-05-22 16:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-22  5:24 [PATCH] namespaces: uts_ns: make information visible via /proc/PID/uts directory Sam Vilain
2006-05-22  8:04 ` Andrew Morton
2006-05-22 21:31   ` Sam Vilain
2006-05-22 11:45 ` Alan Cox
2006-05-22 23:07   ` Sam Vilain
2006-05-22 23:10     ` Sam Vilain
2006-05-22 23:49       ` Sam Vilain
2006-05-22 14:03 ` Herbert Poetzl
2006-05-22 16:39 ` Eric W. Biederman [this message]
2006-05-22 23:18   ` Sam Vilain
  -- strict thread matches above, loose matches on Subject: below --
2006-05-22  5:23 Sam Vilain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m11wumm2tv.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=akpm@osdl.org \
    --cc=clg@fr.ibm.com \
    --cc=dev@sw.ru \
    --cc=devel@openvz.org \
    --cc=haveblue@us.ibm.com \
    --cc=herbert@13thfloor.at \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@vilain.net \
    --cc=serue@us.ibm.com \
    --cc=xemul@sw.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox