From: ebiederm@xmission.com (Eric W. Biederman)
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Dave Hansen <haveblue@us.ibm.com>,
linux-kernel@vger.kernel.org, serue@us.ibm.com,
frankeh@watson.ibm.com, clg@fr.ibm.com,
Herbert Poetzl <herbert@13thfloor.at>,
Sam Vilain <sam@vilain.net>
Subject: Re: [RFC][PATCH 1/6] prepare sysctls for containers
Date: Sun, 19 Mar 2006 07:50:42 -0700 [thread overview]
Message-ID: <m13bhexzct.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060307015741.GM27946@ftp.linux.org.uk> (Al Viro's message of "Tue, 7 Mar 2006 01:57:41 +0000")
Al Viro <viro@ftp.linux.org.uk> writes:
> On Mon, Mar 06, 2006 at 05:55:48PM -0800, Dave Hansen wrote:
>> On Tue, 2006-03-07 at 01:24 +0000, Al Viro wrote:
>> > This is disgusting. Please, don't pile more and more complexity into
>> > sysctl_table - it's already choke-full of it and needs to be simplified,
>> > not to grow more crap.
>>
>> I don't completely disagree. It certainly isn't the most elegant
>> approach I've ever seen.
>>
>> Any ideas on ways we could simplify it? I was thinking that we could
>> get rid of the .data member and allow access only via the mechanism I
>> just introduced. It would be pretty easy to make some macros to
>> generate "simple" access functions for the existing global variables.
>
> I'll resurrect the sysctl-cleanups tree and drop it on kernel.org tonight.
Has that happened yet?
I just looked and I didn't see anything up there.
Eric
next prev parent reply other threads:[~2006-03-19 14:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-06 23:52 [RFC][PATCH 0/6] support separate namespaces for sysv Dave Hansen
2006-03-06 23:52 ` [RFC][PATCH 1/6] prepare sysctls for containers Dave Hansen
2006-03-07 0:50 ` Herbert Poetzl
2006-03-07 2:00 ` Dave Hansen
2006-03-07 2:45 ` Herbert Poetzl
2006-03-19 15:54 ` Eric W. Biederman
2006-03-07 1:01 ` Chris Wright
2006-03-07 2:04 ` Dave Hansen
2006-03-07 2:18 ` Chris Wright
2006-03-07 3:02 ` Sam Vilain
2006-03-07 1:24 ` Al Viro
2006-03-07 1:55 ` Dave Hansen
2006-03-07 1:57 ` Al Viro
2006-03-19 14:50 ` Eric W. Biederman [this message]
2006-03-19 15:29 ` Eric W. Biederman
2006-03-06 23:52 ` [RFC][PATCH 2/6] sysvmsg: containerize Dave Hansen
2006-03-07 1:57 ` Chris Wright
2006-03-07 2:08 ` Dave Hansen
2006-03-07 2:34 ` Chris Wright
2006-03-19 15:36 ` Eric W. Biederman
2006-03-20 19:34 ` Chris Wright
2006-03-20 21:29 ` Eric W. Biederman
2006-03-20 21:50 ` Chris Wright
2006-03-06 23:52 ` [RFC][PATCH 3/6] sysvmsg: containerize sysctls Dave Hansen
2006-03-06 23:52 ` [RFC][PATCH 4/6] sysvsem: containerize Dave Hansen
2006-03-07 2:44 ` Chris Wright
2006-03-07 5:08 ` Dave Hansen
2006-03-06 23:52 ` [RFC][PATCH 5/6] sysvshm: containerize Dave Hansen
2006-03-06 23:52 ` [RFC][PATCH 6/6] sysvshm: containerize sysctls Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m13bhexzct.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=clg@fr.ibm.com \
--cc=frankeh@watson.ibm.com \
--cc=haveblue@us.ibm.com \
--cc=herbert@13thfloor.at \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@vilain.net \
--cc=serue@us.ibm.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox