From: Rusty Russell <rusty@rustcorp.com.au>
To: npollitt@engr.sgi.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Process pinning
Date: Wed, 11 Apr 2001 21:05:47 +1000 [thread overview]
Message-ID: <m14nIRX-001RovC@mozart> (raw)
In-Reply-To: Your message of "Mon, 09 Apr 2001 17:08:23 MST." <20010409170823.C2316@engr.sgi.com>
In message <20010409170823.C2316@engr.sgi.com> you write:
> Changes to array.c expose cpus_allowed in proc/pid/stat.
Call me old fashioned, but I prefer my bitmasks in hex.
Please also consider changing:
still_running:
c = goodness(prev, this_cpu, prev->active_mm);
next = prev;
to:
still_running:
if (prev & (1 << this_cpu)) {
c = goodness(prev, this_cpu, prev->active_mm);
next = prev;
}
Otherwise, you will keep scheduling a RT process forever on a
disallowed CPU on which it is already running. And even a non-RT
process will stick on its disallowed CPU as long as nothing else runs
there.
Learnt this the hard way from the hotplug CPU patch...
Rusty.
--
Premature optmztion is rt of all evl. --DK
next prev parent reply other threads:[~2001-04-17 10:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-10 0:08 [PATCH] Process pinning Nick Pollitt
2001-04-11 11:05 ` Rusty Russell [this message]
2001-04-17 16:17 ` Tim Hockin
2001-04-17 19:25 ` Andrew Morton
2001-04-18 1:24 ` Albert D. Cahalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m14nIRX-001RovC@mozart \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=npollitt@engr.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox