Re: [PATCH] Make Documentation/kobject.txt a little more coherent.

[ebiederm@xmission.com (Eric W. Biederman)]

Rusty Russell <rusty@rustcorp.com.au> writes:

> While reading Documentation/kobject.txt:
>
>   Note kobject_rename does perform any locking or have a solid notion of
>   what names are valid so the provide must provide their own sanity checking
>   and serialization.
>
> I expect better: You never see me hard with time word making sentence
> coherent stuff.  Ever.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>

Yes.  That does sound better.


> diff --git a/Documentation/kobject.txt b/Documentation/kobject.txt
> --- a/Documentation/kobject.txt
> +++ b/Documentation/kobject.txt
> @@ -118,8 +118,8 @@ the name of the kobject, call kobject_re
>  
>      int kobject_rename(struct kobject *kobj, const char *new_name);
>  
> -Note kobject_rename does perform any locking or have a solid notion of
> -what names are valid so the provide must provide their own sanity checking
> +kobject_rename does not perform any locking or have a solid notion of
> +what names are valid so the caller must provide their own sanity checking
>  and serialization.
>  
>  There is a function called kobject_set_name() but that is legacy cruft and