public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Make Documentation/kobject.txt a little more coherent.
@ 2008-12-08 22:02 Rusty Russell
  2008-12-08 22:52 ` Eric W. Biederman
  0 siblings, 1 reply; 2+ messages in thread
From: Rusty Russell @ 2008-12-08 22:02 UTC (permalink / raw)
  To: Eric W. Biederman; +Cc: Greg KH, linux-kernel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 1159 bytes --]

While reading Documentation/kobject.txt:
  Note kobject_rename does perform any locking or have a solid notion of  what names are valid so the provide must provide their own sanity checking  and serialization.
I expect better: You never see me hard with time word making sentencecoherent stuff.  Ever.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff --git a/Documentation/kobject.txt b/Documentation/kobject.txt--- a/Documentation/kobject.txt+++ b/Documentation/kobject.txt@@ -118,8 +118,8 @@ the name of the kobject, call kobject_re      int kobject_rename(struct kobject *kobj, const char *new_name); -Note kobject_rename does perform any locking or have a solid notion of-what names are valid so the provide must provide their own sanity checking+kobject_rename does not perform any locking or have a solid notion of+what names are valid so the caller must provide their own sanity checking and serialization.  There is a function called kobject_set_name() but that is legacy cruft and\0ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Make Documentation/kobject.txt a little more coherent.
  2008-12-08 22:02 [PATCH] Make Documentation/kobject.txt a little more coherent Rusty Russell
@ 2008-12-08 22:52 ` Eric W. Biederman
  0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2008-12-08 22:52 UTC (permalink / raw)
  To: Rusty Russell; +Cc: Greg KH, linux-kernel

Rusty Russell <rusty@rustcorp.com.au> writes:

> While reading Documentation/kobject.txt:
>
>   Note kobject_rename does perform any locking or have a solid notion of
>   what names are valid so the provide must provide their own sanity checking
>   and serialization.
>
> I expect better: You never see me hard with time word making sentence
> coherent stuff.  Ever.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>

Yes.  That does sound better.


> diff --git a/Documentation/kobject.txt b/Documentation/kobject.txt
> --- a/Documentation/kobject.txt
> +++ b/Documentation/kobject.txt
> @@ -118,8 +118,8 @@ the name of the kobject, call kobject_re
>  
>      int kobject_rename(struct kobject *kobj, const char *new_name);
>  
> -Note kobject_rename does perform any locking or have a solid notion of
> -what names are valid so the provide must provide their own sanity checking
> +kobject_rename does not perform any locking or have a solid notion of
> +what names are valid so the caller must provide their own sanity checking
>  and serialization.
>  
>  There is a function called kobject_set_name() but that is legacy cruft and

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-12-08 22:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-08 22:02 [PATCH] Make Documentation/kobject.txt a little more coherent Rusty Russell
2008-12-08 22:52 ` Eric W. Biederman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox