From: Andi Kleen <ak@muc.de>
To: Ross Biro <rossb@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC/Patch 2.6.11] Take control of PCI Master Abort Mode
Date: Sun, 10 Apr 2005 15:29:10 +0200 [thread overview]
Message-ID: <m14qee221l.fsf@muc.de> (raw)
In-Reply-To: <4252E827.4080807@google.com> (Ross Biro's message of "Tue, 05 Apr 2005 12:33:59 -0700")
Ross Biro <rossb@google.com> writes:
>
> I even have a single motherboard with both a device that cannot handle
> the target abort and an IDE controller that can handle the target
> abort behind the same bridge. For this motherboard, I have to choose
> the lesser of two evils, network hiccups or potential data corruption.
> For the record, I have seen both occur. Other people may make wish to
> make a different choice than we did, hence this patch allows the user
> to choose the mode at runtime.
I think it is totally wrong to make this Configs and boot options.
Nobody can do anything with such obscure boot configurations
and it is bad to require kernel recompiles for such things.
The right way to do this would be to have sysfs knobs that allow
to change these bits, and then let a user space tool change
it depending on PCI-ID. If the issue is critical enough
that it happens very often then it should be added to kernel
pci quirks - but again be unconditional.
-Andi
next prev parent reply other threads:[~2005-04-10 13:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-05 19:33 [RFC/Patch 2.6.11] Take control of PCI Master Abort Mode Ross Biro
2005-04-05 20:53 ` Randy.Dunlap
2005-04-06 12:47 ` Ross Biro
2005-04-06 20:44 ` Daniel Egger
2005-04-10 13:29 ` Andi Kleen [this message]
[not found] ` <8783be66050412075218b2b0b0@mail.gmail.com>
2005-04-13 18:37 ` Andi Kleen
2005-04-13 23:00 ` Ross Biro
2005-04-13 23:28 ` Dave Jones
2005-04-14 17:25 ` Ross Biro
2005-04-14 17:34 ` Tim Hockin
2005-04-14 18:02 ` Andi Kleen
2005-04-14 18:33 ` Dave Jones
2005-04-14 19:14 ` Daniel Egger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m14qee221l.fsf@muc.de \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rossb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox