public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Martin Clausen <martin@ostenfeld.dk>
Cc: netfilter-devel@lists.samba.org, linux-kernel@vger.kernel.org,
	James Morris <jmorris@intercode.com.au>
Subject: Re: Kernel Oops when using the Netfilter QUEUE target
Date: Fri, 27 Apr 2001 23:42:15 +1000	[thread overview]
Message-ID: <m14t8Vj-001QOfC@mozart> (raw)
In-Reply-To: Your message of "Fri, 27 Apr 2001 00:48:01 +0200." <20010427004801.A3464@ostenfeld.dk>

In message <20010427004801.A3464@ostenfeld.dk> you write:
> On Wed, Apr 25, 2001 at 04:24:46PM +1000, James Morris wrote:
> > Please try the patch below.
> 
> So i did and it seems to work just fine (= no more oops') under 2.4.3/2.4.2-a

James,  I only glanced at the patch, but IIRC it just did
route_me_harder() on everything.  This is, unfortunately, no longer
"Best Practice": the prevailing trend is to reroute only when
something has actually been changed, to avoid overriding the socket
binding, etc.

See mangle for an example (store old values, see if they changed).  I
think this would be more complex, but still possible in your case, no?

Thanks,
Rusty.
--
Premature optmztion is rt of all evl. --DK

  reply	other threads:[~2001-04-28  4:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20010425004937.A3904@ostenfeld.dk>
2001-04-25  6:24 ` Kernel Oops when using the Netfilter QUEUE target James Morris
2001-04-26 22:48   ` Martin Clausen
2001-04-27 13:42     ` Rusty Russell [this message]
2001-04-24 17:25 Martin Clausen
2001-04-26  3:13 ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m14t8Vj-001QOfC@mozart \
    --to=rusty@rustcorp.com.au \
    --cc=jmorris@intercode.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@ostenfeld.dk \
    --cc=netfilter-devel@lists.samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox